New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUC472/M453] Support unique locally administered MAC address and other driver updates #3918

Merged
merged 10 commits into from Mar 22, 2017

Conversation

Projects
None yet
5 participants
@cyliangtw
Contributor

cyliangtw commented Mar 10, 2017

This PR patches for the targets NuMaker-PFM-NUC472 and NuMaker-PFM-M453 and has the following modifications:

  1. Support unique locally administered MAC address.
  2. Refine serial & SPI PDMA code
  3. Refine pwmout power-down condition
  4. Refine pin/peripheral/pin map definitions
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 10, 2017

How was this tested? It would be nice to share any test results.

@cyliangtw

This comment has been minimized.

Contributor

cyliangtw commented Mar 13, 2017

Attached tls_client test log, to prove
unique locally administered MAC address
More, passed all mbed test cases except the network connection between device and my PC (i.e: it's our working PC proxy limitation).
tls_client.txt
mbed_test_arm_0313.txt

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 14, 2017

retest uvisor

mac[2] = (word0 & 0xff000000) >> 24;
mac[3] = (word0 & 0x00ff0000) >> 16;
mac[4] = (word0 & 0x0000ff00) >> 8;
mac[5] = (word0 & 0x000000ff);
// printf("mac address %02x-%02x-%02x-%02x-%02x-%02x \r\n", mac[0], mac[1],mac[2],mac[3],mac[4],mac[5]);

This comment has been minimized.

@0xc0170

0xc0170 Mar 14, 2017

Member

please remove this debug msg

@0xc0170

Just that one commented debug printf.

LGTM

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 14, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 14, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 14, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 14, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1683

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 15, 2017

@sg- sg- merged commit 2d2479a into ARMmbed:master Mar 22, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment