Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't set the build_dir to anything on export #3924
When constructing a toolchain for export, we currently set the
In this patch we set the
Looks like there's a build failure with K64F for the mbed-client-testapp?
referenced this pull request
Mar 16, 2017
@theotherjimmy This is a bugfix for a bug that is on master and even on 5.4 branch (I faced this issue locally and took me a while to figure out that this is not my local setup but upstream bug). The importance of this bug is higher than it seems. It clicked all once I started browsing and saw all the reports (were referenced only 2 days ago, but this patch was sent 6 days ago thus we could already know more about this bug 6 days ago?). This could be easily integrated for the last release but was not as the description was lacking details, and even after improved, I still don't find it enough. For instance, when was this bug introduced? I had to go to the history, this one : theotherjimmy@fbb6f71. So this is fixing already another fix that introduced this bug. How can I reproduce this bug ? what does this bugfix fixes? As in the commit message : Before this patch: description here. After this patch: description here.
Please take more time to describe the issue, how this patch fixes it and reference issues or any relevant information. I assume this bugfix could be already in the last release!
How come this was not discovered with our build test that the project even fails to export or exported project is empty (only root is scanned, and in my case it was just config header file in the workspace view) ? @theotherjimmy Did you check build tests? I checked the PR that introduced this change, we did not run build CI test ! Here's it : #3852 (no mention of running build CI). Would it fail?
Your command has finished executing! Here's what you wrote!
Example Build failed!