New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DELTA_DFBM_NQ620] Add RC calibration setting and revise mbed_overrides.c #3927

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
4 participants
@TsungtaWu
Contributor

TsungtaWu commented Mar 11, 2017

In targets.json, add lf_clock_rc_calib_timer_interval and
lf_clock_rc_calib_mode_config setting which are essential when using BLE
In mbed_overrides.c, create valuables instead of doing printf, those
valuables are intended to be used for debugging in runtime.

Please kindly review this PR

[DELTA_DFBM_NQ620] Add RC calibration setting and revise mbed_overrid…
…es.c

In targets.json, add lf_clock_rc_calib_timer_interval and
lf_clock_rc_calib_mode_config setting which are essential when using BLE
In mbed_overrides.c, create valuables instead of doing printf, those
valuables are intended to be used for debugging in runtime.
"config": {
"lf_clock_rc_calib_timer_interval": {
"value": 16,
"macro_name": "MBED_CONF_NORDIC_NRF_LF_CLOCK_CALIB_TIMER_INTERVAL"

This comment has been minimized.

@0xc0170

0xc0170 Mar 13, 2017

Member

aren't this values defined by config as they are here or why do you need to specify macro_name?

This comment has been minimized.

@TsungtaWu

TsungtaWu Mar 14, 2017

Contributor

@0xc0170 I follow the instruction stated in \targets\TARGET_NORDIC\TARGET_NRF5\LF_Clock_config.md
I have tried to use “marcos_add” instead of “marco_name”, but the compiled BLE_HeartRate won’t work on DELTA_DFBM_NQ620
Any suggestion?

This comment has been minimized.

@0xc0170

0xc0170 Mar 14, 2017

Member

Thanks for the info, LGTM

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 14, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 14, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 14, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1682

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 14, 2017

@adbridge adbridge merged commit cc58a7f into ARMmbed:master Mar 14, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment