New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUCLEO_F302R8: Add missing PB_8/PB_9 CAN pins #3969

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
4 participants
@bcostm
Contributor

bcostm commented Mar 20, 2017

Description

Add missing PB_8/PB_9 CAN pins. These pins were commented by mistake.

Status

READY

Migrations

NO

@@ -226,13 +226,13 @@ const PinMap PinMap_SPI_SSEL[] = {
};

const PinMap PinMap_CAN_RD[] = {
// {PB_8 , CAN_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF9_CAN)}, // Not available in 32 pins package
{PB_8 , CAN_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF9_CAN)},

This comment has been minimized.

@0xc0170

0xc0170 Mar 20, 2017

Member

how come they are now available? the previous comment says 32pins package does not contain these pins?

This comment has been minimized.

@bcostm

bcostm Mar 20, 2017

Contributor

This comment was a mistake. The package used on this board is a 64pin and not a 32pin. So these pins are available.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 21, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 21, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 21, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1708

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 21, 2017

@sg- sg- merged commit 75f6f2d into ARMmbed:master Mar 22, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:fix_nucleo-f302r8_can_pins branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment