Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix mbed-cli issue #468. Add LPCTargetCode.lpc_patch to POST_BINARY_WHITELIST #4085
Although the post_binary_hooks are not used by the exporters at this time, the exporters do set up a POST_BINARY_WHITELIST and reject anything with a post_binary_hook not in the whitelist. This prevents LPCTargets from working with exporters. This patch adds the LPCTarget to the whitelist of all exporters.
It looks like you pushed the commit that fixes the other issue onto this branch. Could you create a feature branch for that commit and submit it as a separate PR? This will reduce the time it takes to get these PRs merged, and keep the discussions in each PR focused.
Yeah - just saw that. Didn't know that was going to happen. Sorry about that. Thought I could use my fork over and over for different PRs. (I see now that I should create a feature branch on my fork for each different PR, right?)
So, what state did I leave the fork in? Is the PR for this specific issue (#468) now screwed up?
You can, with different branches.