New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when mbed_app.json is bad #4098

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
6 participants
@theotherjimmy
Contributor

theotherjimmy commented Mar 31, 2017

Resolves ARMmbed/mbed-cli#471

Testing

  • /morph test
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 31, 2017

Travis failure is reproducible. Working on it now.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fail-on-bad-config branch Mar 31, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 31, 2017

I think I got the travis errors.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 31, 2017

/morph test

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fail-on-bad-config branch to 1faf44e Mar 31, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 31, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1810

Test Prep failed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 31, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 31, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1811

All builds and test passed!

@0xc0170

0xc0170 approved these changes Apr 1, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 7, 2017

@sg- merge this or?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 7, 2017

Looks like this just got missed on clicking the merge button - LGTM

@adbridge adbridge merged commit a514216 into ARMmbed:master Apr 7, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment