New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GNU ARM Eclipse .mbedignore file with jinja2 #4168

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 11, 2017

Descritpion

There are subtleties about where the exporters generate files when using
the online exporers-as-a-service. Simply calling open does not do the
correct thing in this environment. The self.gen_file method can be used
instead to account for these differences.

I saw an exception generated by the online build system recently.
This was the traceback:

IOError: [Errno 13] Permission denied: '.mbedignore'
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/views/decorators/vary.py", line 21, in inner_func
    response = func(*args, **kwargs)
  File "piston/resource.py", line 190, in __call__
    result = self.error_handler(e, request, meth, em_format)
  File "piston/resource.py", line 188, in __call__
    result = meth(request, *args, **kwargs)
  File "mbed/api/api_misc.py", line 262, in create
    inc_repos=request.POST.get('inc_repos'))
  File "mbed_compiler/export.py", line 149, in export
    notify=notify
  File "tools/project_api.py", line 222, in export_project
    macros=macros)
  File "tools/project_api.py", line 89, in generate_project_files
    exporter.generate()
  File "tools/export/gnuarmeclipse/__init__.py", line 281, in generate
    with open('.mbedignore', 'w') as f:

How to reproduce

Export a project to gnuarmeclipse on the online exporters-as-a-service.

New behavior

It should be resolved with this change, and export correctly

Testing

  • /morph export-build

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:gnuarmeclipse-more-templates branch Apr 11, 2017

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:gnuarmeclipse-more-templates branch to 6fa1de2 Apr 11, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 11, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 160

All exports and builds passed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 12, 2017

retest uvisor

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 12, 2017

@0xc0170 All green!

@sg- sg- merged commit de6cce7 into ARMmbed:master Apr 19, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment