New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail IAR exports without linker scirpts with NotSupportedException #4172

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 11, 2017

How to reproduce

Delete a linker script.
For example:

 rm mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/device/TOOLCHAIN_IAR/MK64FN1M0xxx12.icf 

Then try to export that Target to IAR:

Traceback (most recent call last):
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/project.py", line 247, in <module>
    main()
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/project.py", line 243, in main
    build_profile=profile)
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/project.py", line 93, in export
    build_profile=build_profile, silent=silent)
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/__init__.py", line 329, in export_project
    macros=macros)
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/__init__.py", line 196, in generate_project_files
    exporter.generate()
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/iar/__init__.py", line 125, in generate
    'linker_script': self.format_file(self.resources.linker_script),
  File "/home/jimbri01/src/armmbed/mbed-os-example-fat-filesystem/mbed-os/tools/export/iar/__init__.py", line 92, in format_file
    return join('$PROJ_DIR$',file)
  File "/usr/lib/python2.7/posixpath.py", line 68, in join
    if b.startswith('/'):
AttributeError: 'NoneType' object has no attribute 'startswith'

That should not happen

New behavior

tools.utils.NotSupportedException: No linker script found.

Testing

  • /morph export-bulid
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 11, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 12, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 12, 2017

ImportError: cannot import name NotSupportedExce Travis failure

@0xc0170

NotSupportedException in the import

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 12, 2017

whoops. I though I typed that all the way.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:iar-no-linker-scirpt branch to 1e21985 Apr 12, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 12, 2017

/morph export-build

1 similar comment
@sg-

This comment has been minimized.

Member

sg- commented Apr 19, 2017

/morph export-build

@sg- sg- added needs: CI and removed needs: work labels Apr 19, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 19, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 10

Exporter Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 19, 2017

The failure is for IAR for one nuvoton target : Cannot call intrinsic function "__nounwind __ISB" from Thumb mode in this architecture. I assume it is not related to this changeset, thus master might be broken? I'll restart it here again

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 19, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 12

All exports and builds passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 19, 2017

@adbridge adbridge merged commit 8344adf into ARMmbed:master Apr 20, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment