New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: race test - add not supported for single threaded env #4205

Merged
merged 1 commit into from Apr 24, 2017

Conversation

Projects
None yet
5 participants
@0xc0170
Member

0xc0170 commented Apr 20, 2017

Fixes #4196. As someone might not be aware that settting default_lib to small has
some implications regarding thread safety, therefore we print an error.

tests: race test - add not supported for single threaded env
Fixes #4196. As someone might not be aware that settting default_lib to small has
some implications regarding thread safety, therefore we print an error.

@0xc0170 0xc0170 requested a review from c1728p9 Apr 20, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 21, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 21, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 59

All builds and test passed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 21, 2017

@0xc0170 This is probably not the only test that is not supported. Could you take a look at the remaining tests and insert the same code if applicable?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2017

@0xc0170 This is probably not the only test that is not supported. Could you take a look at the remaining tests and insert the same code if applicable?

Can you pinpoint any? I could not find any (rtos tests contain this error already).

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 24, 2017

If there are no others then let's merge!

@theotherjimmy theotherjimmy merged commit 79bf717 into ARMmbed:master Apr 24, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0xc0170 0xc0170 deleted the 0xc0170:fix_issue4196 branch Apr 26, 2017

exmachina-auto-deployer pushed a commit to exmachina-dev/mbed-os that referenced this pull request May 16, 2017

Merge tag 'mbed-os-5.4.5' of github.com:ARMmbed/mbed-os into feature/…
…lwip_broadcast

Release mbed OS 5.4.5 and mbed lib v142

Ports for Upcoming Targets

Fixes and Changes

4059: [Silicon Labs] Rename targets ARMmbed#4059
4115: Support for Qt Creator Generic project export and associated Makefile ARMmbed#4115
3915: Feature vscode ARMmbed#3915
4205: tests: race test - add not supported for single threaded env ARMmbed#4205
4187: [NCS36510] Reduce default heap size allocated by IAR to 1/4 of RAM ARMmbed#4187
4145: test - add nanostack to examples.json file ARMmbed#4145
4093: Update.py: New feature - update a branch instead of a fork, plus general improvements. ARMmbed#4093
4225: fixed missing device_name for xDot and removed progen ARMmbed#4225
4243: Config: config header file should contain new line ARMmbed#4243
4251: Fix C++11 build error w/ u-blox EVK-ODIN-W2 ARMmbed#4251
4236: STM32 Fixed warning related to __packed redefinition ARMmbed#4236
4224: Add `mbed new .` output to export ARMmbed#4224
4190: LPC4088: Enable LWIP feature ARMmbed#4190
4136: Error when bootloader is specified but does not exist ARMmbed#4136
3881: Remove debug links to printf/exit in NDEBUG builds ARMmbed#3881
4260: Inherit Xadow M0 target from LPC11U35_501 ARMmbed#4260
4249: Add consistent button names across targets ARMmbed#4249
4254: Removed unused variable in TARGET_NXP/lpc17_emac.c ARMmbed#4254
@@ -22,6 +22,10 @@
#include "SingletonPtr.h"
#include <stdio.h>
#ifndef MBED_RTOS_SINGLE_THREAD

This comment has been minimized.

@jeromecoutant

jeromecoutant May 22, 2017

Contributor

Hi
I think this should be ifdef, not ifndef....

This comment has been minimized.

@0xc0170

0xc0170 May 25, 2017

Member

Good catch ! will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment