New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid 03/05 intel-hex records for nordic devices #4276

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
6 participants
@nvlsianpu
Contributor

nvlsianpu commented May 5, 2017

Use Intelhex::write_hex_file instead of IntelHex::tofile do the work.
Mentioned records types has no sense for nordic devices.
Sucha a record comes from *.hex file from the mbed-os sources build.

This PR solves #4237

avoid 03/05 intel-hex records for nordics devices
use Intelhex::write_hex_file instead of IntelHex::tofile
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 5, 2017

I'm curious: why don't you need the start address?

@nvlsianpu

This comment has been minimized.

Contributor

nvlsianpu commented May 6, 2017

For NRF5 any of mbed-os app has a SoftDevice (SD) incorporated. SoftDevice is a BlackBox - the SoC run it thanks to the its reset handler (as for any else cortex-m device) and after some magic Softdevice call the user application. So for Nordic devices we expected run using reset - practical we even don't know where is the reset handler or the main of the SoftDevice.

@pan-

pan- approved these changes May 8, 2017

LGTM

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 8, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 8, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented May 8, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 166

All builds and test passed!

@theotherjimmy theotherjimmy merged commit d04d588 into ARMmbed:master May 8, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label May 8, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 8, 2017

? @sg- did something go awry?

@sg-

This comment has been minimized.

Member

sg- commented May 8, 2017

not sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment