Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Flash api nRF52840 #4282
referenced this pull request
May 8, 2017
3 small things that can help:
first dot: Ok, I'll remember.
second: this header is included in flash_api.h with proper preprocesor if
@kl-cruz Because we're on the subject of commit messages, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. I find commit.template to be particularly useful. Thanks for your contributions.
@0xc0170 How much does  affect things? In our release notes, I've been changing : to  to get rid of the awkward double colon, but if we're recommending that everyone use colons, I may have to consider changing that.
We will have to check to use a flag to overcome this removing  from the commit line for