New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC4088: add "LPC4088Code.binary_hook" to the white list of the embit… #4289

Merged
merged 1 commit into from May 10, 2017

Conversation

Projects
None yet
4 participants
@netzimme
Contributor

netzimme commented May 8, 2017

Add "LPCTargetCode.lpc_patch" to the white list of the embitz, gnuarmeclipse and makefile exporter.

Description

With this changes it is possible to export the programs for LPC4088 as embitz, gnuarmeclipse or makefile project.

@netzimme

This comment has been minimized.

Contributor

netzimme commented May 8, 2017

@sg- sg- requested a review from theotherjimmy May 9, 2017

@sg- sg- added the needs: review label May 9, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2017

You added LPC4088Code.binary_hook to the white-list. Could you update the commit message to reflect that?

I should run /morph export-build after you do

@theotherjimmy theotherjimmy changed the title from LPC4088: add "LPCTargetCode.lpc_patch" to the white list of the embit… to LPC4088: add "LPC4088Code.binary_hook" to the white list of the embit… May 9, 2017

@theotherjimmy

Good work. This is the correct way to enable exports for these targets.

@netzimme

This comment has been minimized.

Contributor

netzimme commented May 9, 2017

Change the title of the patch.

Thanks

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2017

@netzimme did you push the changed patch?

@netzimme

This comment has been minimized.

Contributor

netzimme commented May 9, 2017

Now I push the change.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2017

Hmmmmm.... it seems that you changed the title then merged the two together. I don't think that's what you intended to do.

@theotherjimmy theotherjimmy force-pushed the netzimme:master branch to 8e02855 May 9, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2017

There we go! That's correct.

@netzimme

This comment has been minimized.

Contributor

netzimme commented May 9, 2017

Fine :-)

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented May 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 28

All exports and builds passed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2017

@netzimme Are the executables created from theses new exports flashing correctly?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2017

Please don't show me mbed test output. That does not impact the exporters.

@netzimme

This comment has been minimized.

Contributor

netzimme commented May 10, 2017

Hello @theotherjimmy

I did test the following exporters with compile/flashing/debugging on the target with the Segger/J-Link probe. I have noticed no problems.

eclipse_gcc_arm
embitz
gcc_arm
gnuarmeclipse
make_gcc_arm
vscode_gcc_arm

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 10, 2017

Awesome! Thanks a bunch @netzimme

@theotherjimmy theotherjimmy merged commit 59e32b2 into ARMmbed:master May 10, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment