New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RO359B] platform added #4302

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
4 participants
@ytsuboi
Contributor

ytsuboi commented May 11, 2017

Description

Adding a new platform RO359B, Wi-Fi module that uses K24F. Re-opened, older one is #4281

Now directory stracture are following, and using inherits on target.json

TARGET_MCUXpresso_MCUS
└TARGET_MCU_K24F
 └TARGET_MCU_K24F1M
  └TARGET_RO359B

Status

READY

Migrations

NO

Steps to test or reproduce

To test this platform with ci-test-shield, pelase use following patch. PWM test need some wiring and this patch.
https://gist.github.com/ytsuboi/9cc9ae551e4775994a89eb88700105c9

Test results. ( I didn't use above test patch for this test. )
RO359B_test_ARM_20170511.txt
RO359B_test_GCC_ARM_20170511.txt
RO359B_test_IAR_20170511.txt

CC @toyowata @0xc0170 @theotherjimmy

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 11, 2017

"inherits": ["MCU_K24F1M"],
"detect_code": ["1022"],
"release_versions": ["2", "5"],
"extra_labels_add": ["RO359B"]

This comment has been minimized.

@theotherjimmy

theotherjimmy May 11, 2017

Contributor

It is not needed, and discouraged, to add yourself to extra_labels.

"MCU_K24F1M": {
"core": "Cortex-M4F",
"supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
"extra_labels": ["Freescale", "MCUXpresso_MCUS", "KSDK2_MCUS", "MCU_K24F", "MCU_K24F1M", "KPSDK_MCUS", "KPSDK_CODE", "FLASH_CMSIS_ALGO"],

This comment has been minimized.

@theotherjimmy

theotherjimmy May 11, 2017

Contributor

Same comment on this line: you don't need to add yourself to extra_labels, and you should not.

@theotherjimmy theotherjimmy changed the title from [RO359B] platform added (re-opened) to [RO359B] platform added May 11, 2017

@ytsuboi

This comment has been minimized.

Contributor

ytsuboi commented May 12, 2017

@theotherjimmy fixed pointed things on your review, and ran tests again.

@0xc0170 0xc0170 added needs: review and removed needs: work labels May 12, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 12, 2017

tools changes and targets.json look fine.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 12, 2017

/morph export-build
/morph test

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 12, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented May 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build
/morph test

Output

mbed Build Number: 32

All exports and builds passed!

@mbed-bot

This comment has been minimized.

mbed-bot commented May 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 201

All builds and test passed!

@0xc0170 0xc0170 merged commit 5af3b0d into ARMmbed:master May 15, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ytsuboi

This comment has been minimized.

Contributor

ytsuboi commented May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment