New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RAM vector table for NCS36510 #4310

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
6 participants
@c1728p9
Contributor

c1728p9 commented May 11, 2017

Fix the ram address of the vector table on the NCS36510. Also reserve space for it in the linker scripts.

This is based on 94a0256 from the CMSIS_5 branch.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented May 11, 2017

/morph test

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented May 12, 2017

retest uvisor

@mbed-bot

This comment has been minimized.

mbed-bot commented May 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 194

All builds and test passed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 12, 2017

@pradeep-gr

This comment has been minimized.

Contributor

pradeep-gr commented May 12, 2017

@pan-

The NCS36510 has 35 vectors, not 36.

The NCS36510 has 35 interrupts with
16 levels of programmable priority

Could you reflect this in the PR ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 12, 2017

@pan- Good catch! This came most probably from https://github.com/c1728p9/mbed-os/blob/d74e219685f1e55a6a01eb4bb7d4f0e3e46759da/targets/TARGET_ONSEMI/TARGET_NCS36510/device/NCS36510.h#L76 (it was set to 36) . As you quoted, the reference manual defines 35.

Fix RAM vector table for NCS36510
Fix the ram address of the vector table on the NCS36510. Also reserve
space for it in the linker scripts.

@c1728p9 c1728p9 force-pushed the c1728p9:fix_ncs36510_vector_table branch to 5cf2255 May 12, 2017

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented May 12, 2017

Good catch @pan-. I updated the comment to reflect the correct number of interrupt vectors. I kept the size the same to keep 8 byte alignment.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented May 12, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented May 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 202

All builds and test passed!

@pan-

pan- approved these changes May 15, 2017

@0xc0170 0xc0170 merged commit 349315a into ARMmbed:master May 15, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment