New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout units in events timing test #4314

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
7 participants
@c1728p9
Contributor

c1728p9 commented May 12, 2017

A units mistake led to passing 20000 seconds instead of 20000 milliseconds to greentea. The would cause the test to spin for 6 hours if it got stuck anywhere.

Taken from commit 8b5dee8 in the CMSIS_5 branch.

Fixed timeout units in events timing test
A units mistake led to passing 20000 seconds instead of 20000 milliseconds
to greentea. The would cause the test to spin for 6 hours if it got stuck
anywhere.

@c1728p9 c1728p9 requested a review from geky May 12, 2017

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented May 12, 2017

/morph test

@geky

geky approved these changes May 12, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 12, 2017

spin for 6 hours if it got stuck anywhere.

Ouch

@mbed-bot

This comment has been minimized.

mbed-bot commented May 13, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 205

All builds and test passed!

@pan-

pan- approved these changes May 15, 2017

@0xc0170 0xc0170 merged commit 865fb95 into ARMmbed:master May 15, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment