New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTS_DRAGONFLY_F411RE/MTS_MDOT_F411RE: add IAR to post_binary_hook toolchains #4368

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
6 participants
@felser
Contributor

felser commented May 22, 2017

Add IAR to post_binary_hook toolchains

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

When building our Dragonfly code (target MTS_DRAGONFLY_F411RE) with ARM or GCC_ARM, our boot loader is properly pre-pended to the bin file. However, when building with the IAR compiler, it is not. Both targets, MTS_DRAGONFLY_F411RE and MTS_MDOT_F411RE need the boot loader pre-pended to the bin file to function. This change adds the bin during post build.

Status

READY

Migrations

There are no API changes.

Related PRs

None

Todos

  • Tests
    Make sure the boot loader is pre-pended when compiling with IAR... I have confirmed for both products.

Deploy notes

None.

Steps to test or reproduce

Compile off line for IAR..
mbed compile -c -t IAR -m MTS_DRAGONFLY_F411RE
Confirm that the resulting bin file runs on the target device. The boot loader takes up 64K so the resulting bin should should at least be larger than 64K. Building blinky is about 92K with the boot loader.

Add IAR to post_binary_hook toolchains so the boot loader is pre-pend…
…ed to the binary file when using the IAR compiler.
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 22, 2017

@felser Could you fill in the pull request template? Could you include the target information in the title? We use the titles of pull requests in the release notes.

@felser felser changed the title from Add IAR to post_binary_hook toolchains so the boot loader is pre-pend… to For targets MTS_DRAGONFLY_F411RE and MTS_MDOT_F411RE, add IAR to post_binary_hook toolchains so the boot loader is pre-pended to the binary file when using the IAR compiler. May 22, 2017

@AnotherButler

This comment has been minimized.

Contributor

AnotherButler commented May 23, 2017

@felser Thanks for the PR and for updating your title.

As @theotherjimmy mentioned, we use PR info in our release notes. For this reason and to keep the commit history clear, we recommend our contributors follow Chris Beam’s seven rules of great commit messages. We find the commit.template feature particularly helpful.

To match this format, please shorten your subject line to 50 characters, and delete the period at the end of the subject line.

Thanks for your contributions.

@0xc0170 0xc0170 changed the title from For targets MTS_DRAGONFLY_F411RE and MTS_MDOT_F411RE, add IAR to post_binary_hook toolchains so the boot loader is pre-pended to the binary file when using the IAR compiler. to MTS_DRAGONFLY_F411RE/MTS_MDOT_F411RE: add IAR to post_binary_hook toolchains Jun 5, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jun 5, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 5, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 5, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 441

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 5, 2017

@adbridge adbridge merged commit f6d1972 into ARMmbed:master Jun 5, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment