New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nucleo-F070RB It doesn't work when use internal clock #4390

Merged
merged 2 commits into from Jun 26, 2017

Conversation

Projects
None yet
6 participants
@mickeyln
Contributor

mickeyln commented May 25, 2017

Description

Nucleo-F070RB have a wrong divisor when it initial the clock.

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Steps to test or reproduce

Run display message to UART

Fixes #4361

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 25, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 25, 2017

@adustm

adustm approved these changes May 29, 2017

Apart from the comment to be moved, it is ok. Thank you for your support

@@ -450,7 +450,7 @@ uint8_t SetSysClock_PLL_HSI(void)
RCC_OscInitStruct.LSIState = RCC_LSI_OFF;
RCC_OscInitStruct.PLL.PLLState = RCC_PLL_ON;
RCC_OscInitStruct.PLL.PLLSource = RCC_PLLSOURCE_HSI; // HSI div 2

This comment has been minimized.

@adustm

adustm May 29, 2017

Member

Hello, could you move the comment to the line you modified, please ?
Otherwise looks good to me.

This comment has been minimized.

@mickeyln

mickeyln Jun 1, 2017

Contributor

Updated

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2017

@mickeyln can you please sign https://developer.mbed.org/contributor_agreement/ ?

Bump, please can you?

@sg- sg- changed the title from [Nucleo-F070RB] It doesn't work when use internal clock to Nucleo-F070RB It doesn't work when use internal clock Jun 15, 2017

@mickeyln

This comment has been minimized.

Contributor

mickeyln commented Jun 20, 2017

I had signed the Agreement.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 21, 2017

I had signed the Agreement.

What is your nick on developer mbed page? I can't locate mickeyln there.

We would like to progress with this patch

@mickeyln

This comment has been minimized.

Contributor

mickeyln commented Jun 22, 2017

https://developer.mbed.org/users/MickeyLin/
Is this what you want?

@0xc0170 0xc0170 added needs: CI and removed needs: CLA labels Jun 22, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jun 23, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 23, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 626

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 26, 2017

@theotherjimmy theotherjimmy merged commit 0d2fb2d into ARMmbed:master Jun 26, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment