New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_F413ZH: Add new platform #4410

Merged
merged 20 commits into from Jun 23, 2017

Conversation

Projects
None yet
7 participants
@arostm
Contributor

arostm commented May 31, 2017

Description

This PR add this new board

Status

READY

##Test Report
F413ZH.zip

Migrations

NO

CC @bcostm @adustm @jeromecoutant @LMESTM

@sg-

This comment has been minimized.

Member

sg- commented Jun 3, 2017

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jun 5, 2017

I think it is due to the line 234 in build_travis.py (rtos)

@0xc0170

has this been tested (updated to the latest master - rtx2 ) ?

tools/build_travis.py Outdated
{"target": "DISCO_F413ZH",
"toolchains": "GCC_ARM",
"tests": {"" : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
"rtos" : ["RTOS_1", "RTOS_2", "RTOS_3"],

This comment has been minimized.

@0xc0170

0xc0170 Jun 5, 2017

Member

please remove rtos from here

@arostm arostm force-pushed the arostm:dev_disco_f413ZH branch Jun 6, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2017

There are conflicts, please resolve.

@arostm arostm force-pushed the arostm:dev_disco_f413ZH branch Jun 12, 2017

@arostm

This comment has been minimized.

Contributor

arostm commented Jun 12, 2017

Hello, I did a rebase

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jun 12, 2017

tools/build_travis.py Outdated
{ "target": "DISCO_F407VG", "toolchains": "GCC_ARM", "libs": ["dsp", "usb"] },
{ "target": "DISCO_F413ZH", "toolchians": "GCC_ARM", "libs": ["dsp", "usb"]},

This comment has been minimized.

@theotherjimmy

theotherjimmy Jun 12, 2017

Contributor

This typo is breaking travis CI:
toolchians => toolchains

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 12, 2017

@arostm Could you fix the aforementioned typo?

@arostm

This comment has been minimized.

Contributor

arostm commented Jun 13, 2017

Hello, I did the modification in build_travis.py. Sorry for the mistake

@arostm arostm force-pushed the arostm:dev_disco_f413ZH branch Jun 15, 2017

@arostm

This comment has been minimized.

Contributor

arostm commented Jun 15, 2017

After a rebase, all the tests are ok, can you approve and merge it ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 15, 2017

After a rebase, all the tests are ok, can you approve and merge it ?

Thanks ! We will review the latest rebase and run CI afterwards.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 21, 2017

@arostm Sorry there was another merge that caused conflicts here for the previous release. we would like to proceed with this one, can you please rebase?

@arostm arostm force-pushed the arostm:dev_disco_f413ZH branch to b5af4c4 Jun 22, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 22, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 22, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 612

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 22, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jun 23, 2017

LGTM

@adbridge adbridge merged commit f1d0314 into ARMmbed:master Jun 23, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment