New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for correct library naming in Travis CI #4516

Merged
merged 5 commits into from Jun 15, 2017

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Jun 9, 2017

Description

Preventative maintenance for exporters. The build tools are able to handle
incorrectly named libraries, but the exporters can't. This PR adds a CI check
in Travis CI that will prevent incorrectly named libraries from coming in.

Status

ready

Testing

  • Just Travis CI is fine
@0xc0170

0xc0170 approved these changes Jun 9, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 9, 2017

Dang @0xc0170 That was fast!

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:filname-ci branch to 3161cf3 Jun 9, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 9, 2017

@0xc0170 Apparently, I was not done yet

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 9, 2017

the red x on 3161cf3 was Travis auto-canceling itself.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 9, 2017

@sg- Looks like it's passing. LGTM.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 9, 2017

Example of what the error will look like:

$ find -name "*.a" -and -not -name "lib*" | tee BUILD/badlibs | sed -e "s/^/Bad library name found: /" && [ ! -s BUILD/badlibs ]
Bad library name found: ./targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/TOOLCHAIN_IAR/rom.a
$ echo $?
1
@bridadan

No need to fire morph on this since its just touching travis stuff. LGTM.

@bridadan bridadan added ready for merge and removed needs: CI labels Jun 12, 2017

@bridadan

This comment has been minimized.

Contributor

bridadan commented Jun 12, 2017

@theotherjimmy @0xc0170 Marked as ready for merge just to prevent people from adding morph commands. Feel free to take the tag off if it's not ready yet.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 12, 2017

@bridadan I need to add IAR library checking. just a sec.

@sg- sg- merged commit f16ca56 into ARMmbed:master Jun 15, 2017

3 checks passed

Cam-CI uvisor Build & Test Success
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment