New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase background stack size to fix overflow #4563

Merged
merged 3 commits into from Jun 19, 2017

Conversation

Projects
None yet
6 participants
@c1728p9
Contributor

c1728p9 commented Jun 14, 2017

Bump the background stack size to 512 bytes to fix stack overflows on the NRF52 and so it is the same size as it was before the switch to RTX5.

Increase background stack size to fix overflow
Bump the background stack size to 512 bytes to fix stack overflows on
the NRF52 and so it is the same size as it was before the switch to
RTX5.

@0xc0170 0xc0170 added the needs: CI label Jun 15, 2017

@sg-

This comment has been minimized.

Member

sg- commented Jun 15, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 15, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 560

Build failed!

@pan-

pan- approved these changes Jun 15, 2017

LGTM, it fix the idle loop on the NRF52840.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 15, 2017

@c1728p9 Looks like this caused some examples to no longer fit into 16KB.

pan- added some commits Jun 16, 2017

RTOS: Allow per target definition of OS_IDLE_THREAD_STACK_SIZE.
The stack required for the idle thread is highly dependent on the
target because it will call the sleep function which is target
specific.

While 256 bytes of stack is enough for most targets, others like the
NRF52840 might require more.

With this change, target maintainers can specify the idle thread stack
size in their mbed_rtx.h file.
NRF52840: Adjust idle thread stack size.
A stack size of 256 bytes is not enough on the NRF52840, this patch
changes it to a size of 512 bytes.
@pan-

This comment has been minimized.

Member

pan- commented Jun 16, 2017

@c1728p9 I've extended your PR by allowing targets to override the default value of the idle thread stack size. It makes a lot of sense to let it be defined at targets level because the amount of stack needed is directly correlated to the sleep function which is target specific.

@0xc0170 Please review.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 16, 2017

@pan- should this be a config option?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 17, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 17, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 576

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 19, 2017

@theotherjimmy theotherjimmy merged commit d806121 into ARMmbed:master Jun 19, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment