New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtos: Fix MemoryPool and Queue destructor #4601

Merged
merged 2 commits into from Jun 29, 2017

Conversation

Projects
None yet
7 participants
@pan-
Member

pan- commented Jun 21, 2017

Description

Destructors of MemoryPool and Queue were not defined leaving a resource leak after destruction of any instance of this kind of objects.

This PR adds a destructor for these types which correctly release the resources. As a side effect it also fix the default destructor of the Mail class.

Status

READY

Migrations

NO

Todos

  • Review

@pan- pan- requested review from bulislaw and 0xc0170 Jun 21, 2017

@bulislaw

Good catch, thanks!

@0xc0170 0xc0170 added the needs: CI label Jun 21, 2017

@geky

geky approved these changes Jun 21, 2017

Yay! Nice fix
should finish up #4492

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jun 21, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 21, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 602

Test failed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 26, 2017

@studavekar Was this CI failure related to this PR?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jun 28, 2017

Looks like tests failed logs have not been uploaded to public server, Not exactly sure about the failure.
As I re-collect timing tests failed for this PR which has dependent on load on host machine.

re-trigger the tests
/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 29, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 681

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 29, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 683

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 2ffd264 into ARMmbed:master Jun 29, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment