New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bd: Fix missing init in MBRBlockDevice #4607

Merged
merged 2 commits into from Jun 26, 2017

Conversation

Projects
None yet
5 participants
@geky
Member

geky commented Jun 21, 2017

Looks like an init call was missing to the MBRBlockDevice's child block device. This went unnoticed during testing since not all block devices need an init call to function.

I also added an asert on init to the Heap block device, which will at least find these issues if we run filesystem tests.

related issue #4526
cc @netanelgonen, @theotherjimmy

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Jun 26, 2017

We need this on a patch release as well (5.5.x).

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 26, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 638

All builds and test passed!

@theotherjimmy theotherjimmy merged commit e3e54e5 into ARMmbed:master Jun 26, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment