New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue #4357: NRF52 doesn't support simultaneous use of I2C and SPI. #4634

Merged
merged 2 commits into from Jul 13, 2017

Conversation

Projects
None yet
7 participants
@nvlsianpu
Contributor

nvlsianpu commented Jun 26, 2017

Description

Add Support for sharing resources between SPI and TWI instancess.
This fix the issue #4357: NRF52 doesn't support simultaneous use of I2C and SPI.
Now this resources are reserved by each of hal driver using nRF5 SDK's serial-box mechanism.

Status

READY

targets/TARGET_NORDIC/TARGET_NRF5/spi_api.c Outdated
@@ -277,9 +277,11 @@ void spi_init(spi_t *obj,
}
}
for (i = 0; i < SPI_COUNT; ++i) {
for (i = SPI_COUNT - 1; i < SPI_COUNT; i--) {

This comment has been minimized.

@anangl

anangl Jun 27, 2017

Contributor

The loop condition should be i >= 0.

This comment has been minimized.

@nvlsianpu

nvlsianpu Jun 27, 2017

Contributor

sure: int i.

nvlsianpu added some commits Jun 26, 2017

Bugfix: #4357 simultaneous using of I2C and SPI.
Use serial-box of Nordic nRF5 SDK to share resource between
SPI and I2C.
SPI is allocated from highest hw instance number resource in order
to allocate as many I2C instances as possible.

@nvlsianpu nvlsianpu force-pushed the nvlsianpu:bugfix/issue_4357_I2C_SPI_simultaneously branch to 3236336 Jun 27, 2017

@anangl

anangl approved these changes Jun 27, 2017

@nvlsianpu

This comment has been minimized.

Contributor

nvlsianpu commented Jun 27, 2017

@theotherjimmy travis-ci failure is not related to the changes.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 28, 2017

@nvlsianpu Yep. I restarted travis. It should not fail in the same way this time. I hope it passes.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 3, 2017

retest uvisor

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 3, 2017

@0xc0170

0xc0170 approved these changes Jul 3, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 3, 2017

@MarceloSalazar

This comment has been minimized.

Contributor

MarceloSalazar commented Jul 6, 2017

@0xc0170 what's the status?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

@pan- Would you run your BT testing?

/morph test

@pan-

This comment has been minimized.

Member

pan- commented Jul 10, 2017

@theotherjimmy There is literally no point at running bluetooth tests, this PR fix an i2c and spi issue. None of those peripherals are used during BLE testing.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

Thanks! We'll wait for morph test then.

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 765

All builds and test passed!

@0xc0170 0xc0170 merged commit c295187 into ARMmbed:master Jul 13, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment