New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_L475VG_IOT01A: Fix startup files for cmsis5 #4638

Merged
merged 3 commits into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@bcostm
Contributor

bcostm commented Jun 26, 2017

Description

This PR updates all toolchains startup files after CMSIS5 big update. This is a copy/paste of the code present in the DISCO_L476VG platform (similar device).

Before this patch the program does not even start.

After this patch:

+--------+---------------------------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
| Result | Target                    | Toolchain | Test ID     | Test Description                      | Elapsed Time (sec) | Timeout (sec) | Loops |
+--------+---------------------------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | DTCT_1      | Simple detect test                    |        0.47        |       10      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | EXAMPLE_1   | /dev/null                             |        3.42        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_10     | Hello World                           |        0.37        |       5       |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_11     | Ticker Int                            |       11.36        |       15      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_12     | C++                                   |        1.39        |       10      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_16     | RTC                                   |        4.56        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_2      | stdio                                 |        0.75        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_23     | Ticker Int us                         |       11.39        |       15      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_24     | Timeout Int us                        |       11.56        |       15      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_25     | Time us                               |       11.39        |       15      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_26     | Integer constant division             |        1.42        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_34     | Ticker Two callbacks                  |       11.39        |       15      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_37     | Serial NC RX                          |        7.02        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_38     | Serial NC TX                          |        5.96        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_A1     | Basic                                 |        1.39        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_A21    | Call function before main (mbed_main) |        1.47        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_A9     | Serial Echo at 115200                 |        2.45        |       20      |  1/1  |
| OK     | DISCO_L475VG_IOT01A[F549] | ARM       | MBED_BUSOUT | BusOut                                |        2.31        |       30      |  1/1  |
+--------+---------------------------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
Result: 18 OK

+-------------------------+---------------------+---------------------------------------------------------------+--------+--------------------+-------------+
| target                  | platform_name       | test suite                                                    | result | elapsed_time (sec) | copy_method |
+-------------------------+---------------------+---------------------------------------------------------------+--------+--------------------+-------------+
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | features-frameworks-utest-tests-unit_tests-basic_test         | OK     | 14.51              | shell       |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | features-frameworks-utest-tests-unit_tests-basic_test_default | OK     | 14.51              | shell       |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-integration-basic                                       | OK     | 13.71              | shell       |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-mbedmicro-rtos-mbed-basic                               | OK     | 24.64              | shell       |
+-------------------------+---------------------+---------------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 4 OK
mbedgt: test case report:
+-------------------------+---------------------+---------------------------------------------------------------+---------------------------------+--------+--------+--------+--------------------+
| target                  | platform_name       | test suite                                                    | test case                       | passed | failed | result | elapsed_time (sec) |
+-------------------------+---------------------+---------------------------------------------------------------+---------------------------------+--------+--------+--------+--------------------+
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | features-frameworks-utest-tests-unit_tests-basic_test         | Repeating Test                  | 2      | 0      | OK     | 0.08               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | features-frameworks-utest-tests-unit_tests-basic_test         | Simple Test                     | 1      | 0      | OK     | 0.03               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | features-frameworks-utest-tests-unit_tests-basic_test_default | Repeating Test                  | 2      | 0      | OK     | 0.08               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | features-frameworks-utest-tests-unit_tests-basic_test_default | Simple Test                     | 1      | 0      | OK     | 0.03               |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-integration-basic                                       | tests-integration-basic         | 1      | 0      | OK     | 13.71              |
| DISCO_L475VG_IOT01A-ARM | DISCO_L475VG_IOT01A | tests-mbedmicro-rtos-mbed-basic                               | tests-mbedmicro-rtos-mbed-basic | 1      | 0      | OK     | 24.64              |
+-------------------------+---------------------+---------------------------------------------------------------+---------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 6 OK 

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 26, 2017

@bcostm It looks like a build broke on travis. I have reproduced the error below:

Executing: python tools/build.py -m DISCO_L475VG_IOT01A -t GCC_ARM -j 4 -c --silent --dsp --usb

/home/travis/build/ARMmbed/mbed-os/targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L475xG/TARGET_DISCO_L475VG_IOT01A/system_stm32l4xx.c:86:23: fatal error: nvic_addr.h: No such file or directory

 #include "nvic_addr.h"

Please fix this error.

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jun 26, 2017

Yes sorry I forgot to add this file in the commits...

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 26, 2017

Looks good. I'm currently tracking down a bug that is causing the DISCO_L072CZ to fail on master in travis. If you see that target fail, then it's probably not your fault.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 27, 2017

/morph test

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 27, 2017

@mazimkhan I thinks this one failed to report back to github as well...

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 27, 2017

retest uvisor

@theotherjimmy theotherjimmy added needs: CI and removed needs: work labels Jun 27, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 28, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 670

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 28, 2017

@theotherjimmy theotherjimmy merged commit bb3beda into ARMmbed:master Jun 28, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:fix_cmsis5_disco_l475vg branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment