New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUCLEO_L496ZG: Add new Platform #4650

Merged
merged 28 commits into from Nov 2, 2017

Conversation

Projects
None yet
@pmancele
Contributor

pmancele commented Jun 27, 2017

Description

Add support for the NUCLEO_L496ZG and the STM32L496xG MCUs.
All the toolchains (ARM_MICRO/ARM_STD/IAR/GCC_ARM) have been added but only the GCC_ARM one has been tested on our side.

This PR should resolve #4606.

Status

Ready

This is our first port so feel free to point anything we should change.

Regards

@pmancele pmancele changed the title from NUCLEO_L496ZG: Add new Plateform to NUCLEO_L496ZG: Add new Platform Jun 27, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 27, 2017

@pmancele When #4610 comes in, could you take advantage of that targets.json refactor?

@pmancele

This comment has been minimized.

Contributor

pmancele commented Jun 28, 2017

@theotherjimmy Yes for sure, we noticed the incoming changes.

Description updated.

@0xc0170 0xc0170 added the needs: work label Jun 28, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 28, 2017

@pmancele #4610 is in. Please inherit from the Family STM32 target

@pmancele pmancele force-pushed the catiedev:master branch Jun 28, 2017

@pmancele

This comment has been minimized.

Contributor

pmancele commented Jun 28, 2017

@theotherjimmy done

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 28, 2017

Excellent. Thank you.

@0xc0170

LGTM, just one misaligned line

tools/build_travis.py Outdated
@@ -63,6 +63,7 @@
{ "target": "NUCLEO_F446ZE", "toolchains": "GCC_ARM", "libs": ["dsp", "usb"] },
{ "target": "NUCLEO_F746ZG", "toolchains": "GCC_ARM", "libs": ["dsp", "usb"] },
{ "target": "NUCLEO_F767ZI", "toolchains": "GCC_ARM", "libs": ["dsp", "usb"] },
{ "target": "NUCLEO_L496ZG", "toolchains": "GCC_ARM", "libs": ["dsp"] },

This comment has been minimized.

@0xc0170

0xc0170 Jun 29, 2017

Member

can you align this line ?

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jun 29, 2017

Hi
I don't any issue after review.
I can't test yet, I should receive a board soon :-)
thx

@marrakchino marrakchino force-pushed the catiedev:master branch Jun 30, 2017

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralPins.c Outdated
const PinMap PinMap_ADC[] = {
{PA_0, ADC_1, STM_PIN_DATA_EXT(STM_MODE_ANALOG, GPIO_NOPULL, 0, 5, 0)}, // ADC1_IN5
// {PA_0, ADC_2, STM_PIN_DATA_EXT(STM_MODE_ANALOG, GPIO_NOPULL, 0, 5, 0)}, // ADC2_IN5

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Instead of commenting those lines, we use now this convention: "PA_0_ALT0". With PA_0_ALT0 defined in PinNames.h. You can have a look for example in the DISCO_L475VG_IOT01A target.

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralPins.c Outdated
const PinMap PinMap_I2C_SDA[] = {
{PB_4, I2C_3, STM_PIN_DATA(STM_MODE_AF_OD, GPIO_NOPULL, GPIO_AF4_I2C3)},
// {PB_7, I2C_1, STM_PIN_DATA(STM_MODE_AF_OD, GPIO_NOPULL, GPIO_AF4_I2C1)}, // (pin used by LED2)

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

We have also decided recently to enable all pins even those connected to other board's components. This way anobody who has created his own board with the same device will be able to use this target. We use also this convention "// Connected to LED2".

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralPins.c Outdated
};
//*** PWM ***

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Can you add this comment: "// Warning: Pins using PWM_5 cannot be used as TIMER5 is already used by the us_ticker."

This comment has been minimized.

@pmancele

pmancele Jul 4, 2017

Contributor

I understand that now we enable all pins and use the convention "PA_0_ATL0" for example to let users access to all pins on custom boards. But should I also uncomment the pins using PWM_5 ? I guess no as user shouldn't use them while TIMER5 is used by the ticker.

This comment has been minimized.

@bcostm

bcostm Jul 4, 2017

Contributor

Yes you're right. The pins using PWM_5 must remain commented.

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralPins.c Outdated
{PA_0, PWM_2, STM_PIN_DATA_EXT(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF1_TIM2, 1, 0)}, // TIM2_CH1
// {PA_0, PWM_5, STM_PIN_DATA_EXT(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF2_TIM5, 1, 0)}, // TIM5_CH1
{PA_1, PWM_15, STM_PIN_DATA_EXT(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF14_TIM15, 1, 1)}, // TIM15_CH1N
// {PA_1, PWM_2, STM_PIN_DATA_EXT(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF1_TIM2, 2, 0)}, // TIM2_CH2

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Use PA_1_ALT0 and same for all commented pins

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralPins.c Outdated
{PD_2, UART_5, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF8_UART5)},
{PD_6, UART_2, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF7_USART2)},
{PD_9, UART_3, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF7_USART3)},
{PG_8, LPUART_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF8_LPUART1)},

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Add "// Connected to STDIO_UART_RX"

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralPins.c Outdated
{PC_12, UART_5, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF8_UART5)},
{PD_5, UART_2, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF7_USART2)},
{PD_8, UART_3, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF7_USART3)}, // ARDUINO D1
{PG_7, LPUART_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF8_LPUART1)},

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Add "// Connected to STDIO_UART_TX"

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralNames.h Outdated
@@ -0,0 +1,96 @@
/* mbed Microcontroller Library
*******************************************************************************
* Copyright (c) 2015, STMicroelectronics

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

2017

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PeripheralPins.c Outdated
#include "PeripheralPins.h"
// =====

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Can you add this note instead:

//==============================================================================
// Notes
//
// - The pins mentionned Px_y_ALTz are alternative possibilities which use other
//   HW peripheral instances. You can use them the same way as any other "normal"
//   pin (i.e. PwmOut pwm(PA_7_ALT0);). These pins are not displayed on the board
//   pinout image on mbed.org.
//
// - The pins which are connected to other components present on the board have
//   the comment "Connected to xxx". The pin function may not work properly in this
//   case. These pins may not be displayed on the board pinout image on mbed.org.
//   Please read the board reference manual and schematic for more information.
//
//==============================================================================
#ifdef __cplusplus
extern "C" {
#endif

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Add:

typedef enum {
    ALT0  = 0x100,
    ALT1  = 0x200,
    ALT2  = 0x300,
    ALT3  = 0x400
} ALTx;
targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_NUCLEO_L496ZG/PinNames.h Outdated
#endif
typedef enum {
PA_0 = 0x00,

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

Add:
PA_0_ALT0 = PA_0|ALT0,
whenever it is necessary. We put only used pins not all of them.

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/device/TOOLCHAIN_IAR/stm32l496xx_flash.icf Outdated
/*-Memory Regions-*/
define symbol __ICFEDIT_region_ROM_start__ = 0x08000000;
define symbol __ICFEDIT_region_ROM_end__ = 0x0807FFFF;
define symbol __ICFEDIT_region_ROM_TARA_start__ = 0x08080000; /* TARA Lite Demo */

This comment has been minimized.

@bcostm

bcostm Jul 3, 2017

Contributor

To be removed. Is it from previous project ?

This comment has been minimized.

@pmancele

pmancele Jul 4, 2017

Contributor

Thank you for your review !
I get this file on STM32Cube as indicated here ST porting guide but it seems that I took it from a project example. I will replace it with the template provided by STM32Cube.

@pmancele pmancele force-pushed the catiedev:master branch Jul 4, 2017

@pmancele

This comment has been minimized.

Contributor

pmancele commented Jul 4, 2017

@bcostm The 4 new commits should resolve what you pointed in your review 😉

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jul 4, 2017

Thanks for your contribution.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2017

Thanks @bcostm for the review.

@pmancele Any tests run on this new platform? Can you share the results?

@0xc0170

0xc0170 approved these changes Jul 4, 2017

@pmancele

This comment has been minimized.

Contributor

pmancele commented Jul 4, 2017

@0xc0170 By test you mean the results of mbed test ?
If so, here is the result of the mbed test command :

+-----------------------+---------------+--------------------------------------------------------------------------------------+---------+--------------------+-------------+
| target                | platform_name | test suite                                                                           | result  | elapsed_time (sec) | copy_method |
+-----------------------+---------------+--------------------------------------------------------------------------------------+---------+--------------------+-------------+
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-basic_test                        | OK      | 8.38               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-basic_test_default                | OK      | 8.35               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-case_async_validate               | OK      | 8.53               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-case_control_async                | OK      | 8.35               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-case_control_repeat               | OK      | 10.72              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-case_selection                    | OK      | 8.61               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-case_setup_failure                | OK      | 9.21               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-case_teardown_failure             | OK      | 8.54               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-control_type                      | TIMEOUT | 65.86              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-minimal_async_scheduler           | OK      | 8.38               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-minimal_scheduler                 | OK      | 10.23              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-test_assertion_failure_test_setup | OK      | 8.36               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-test_setup_case_selection_failure | OK      | 8.53               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-frameworks-utest-tests-unit_tests-test_setup_failure                | OK      | 8.57               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-tests-filesystem-heap_block_device                                  | OK      | 8.38               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-tests-filesystem-mbr_block_device                                   | TIMEOUT | 67.38              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-features-tests-filesystem-util_block_device                                  | OK      | 8.91               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-rtos-rtx5-target_cortex_m-tests-memory-heap_and_stack                        | OK      | 8.34               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-events-queue                                                           | TIMEOUT | 67.05              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-events-timing                                                          | OK      | 8.55               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-integration-basic                                                      | OK      | 8.39               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-c_strings                                                 | OK      | 10.5               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-dev_null                                                  | OK      | 8.46               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-echo                                                      | OK      | 8.56               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-flashiap                                                  | OK      | 8.37               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-generic_tests                                             | OK      | 9.48               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-lp_timeout                                                | OK      | 17.89              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-race_test                                                 | OK      | 9.95               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-rtc                                                       | OK      | 19.4               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-stl_features                                              | OK      | 9.33               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-ticker                                                    | OK      | 8.54               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-timeout                                                   | OK      | 8.56               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_drivers-wait_us                                                   | OK      | 8.55               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_functional-callback                                               | OK      | 8.37               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_functional-callback_big                                           | OK      | 8.47               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_functional-callback_small                                         | OK      | 10.21              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_functional-functionpointer                                        | OK      | 8.53               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_hal-flash                                                         | OK      | 8.64               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_hal-lp_ticker                                                     | OK      | 8.52               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_hal-rtc_time                                                      | OK      | 8.53               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbed_hal-ticker                                                        | OK      | 8.56               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-mbed-attributes                                              | OK      | 8.44               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-mbed-call_before_main                                        | OK      | 8.36               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-mbed-cpp                                                     | OK      | 8.47               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-mbed-div                                                     | OK      | 8.39               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-mbed-static_assert                                           | OK      | 8.54               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-basic                                              | OK      | 8.41               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-isr                                                | OK      | 8.57               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-mail                                               | OK      | 8.39               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-malloc                                             | OK      | 25.83              | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-mutex                                              | OK      | 8.45               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-queue                                              | OK      | 8.54               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-semaphore                                          | OK      | 8.52               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-signals                                            | OK      | 8.49               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-threads                                            | OK      | 8.55               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedmicro-rtos-mbed-timer                                              | OK      | 8.57               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedtls-multi                                                          | OK      | 8.54               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-mbedtls-selftest                                                       | OK      | 8.52               | shell       |
| NUCLEO_L496ZG-GCC_ARM | NUCLEO_L496ZG | mbed-os-tests-netsocket-ip_parsing                                                   | OK      | 8.53               | shell       |
+-----------------------+---------------+--------------------------------------------------------------------------------------+---------+--------------------+-------------+
mbedgt: test suite results: 56 OK / 3 TIMEOUT

We also try with success the blinky example and some 6LoWPAN program using the ATMEL Firefly 6LoWPAN shield.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 19, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

/morph uvisor-test

@0xc0170 0xc0170 added needs: CI and removed ready for merge labels Oct 19, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 23, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 23, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 168

Exporter Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 23, 2017

@pmancele The one and only one failure, NUCLEO_L496ZG for uvision does not build, can you please retest blinky example, should be able to reproduce the failure

@bcostm

This comment has been minimized.

Contributor

bcostm commented Oct 24, 2017

I ran mbed export -m NUCLEO_L496ZG -i uvision5 and built the project without any error. I have no access to the ci error. What is it exactly ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 27, 2017

@bcostm thanks for testing. I run it also locally, no errors for me, blinky, uvision5.

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 27, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 169

Exporter Build failed!

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 30, 2017

16:48:46 irq_cm4f.S: Error: #5: cannot open source input file "__UVISION_VERSION SETA 521": No such file or directory
16:48:46 irq_cm4f.S: __UVISION_VERSION SETA 521: 0 warnings, 1 errorirq_cm4f.S: Error: A1067E: Output file specified as 'mbed-os\rtos\TARGET_CORTEX\rtx5\TARGET_RTOS_M4_M7\TOOLCHAIN_ARM\irq_cm4f.S', but it has already been specified as '.\build\irq_cm4f.o'
16:48:46 irq_cm4f.S: error: A1905U: Pre-processor step failed for '__UVISION_VERSION SETA 521'

@theotherjimmy Could this be a tool issue ?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 30, 2017

Maybe. It looks like spaces in an assembly path did not get escaped correctly

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 30, 2017

sigh it's in common code. If that's the case why did this board fail, and no others.

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 31, 2017

On the latest exporter build I can't actually see what the failure was! Re-running
/morph export-build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 31, 2017

From the logs looks like Segmentation fault

"/builds/ws/exporter-build-matrix/37/K66F_make_iar/sources/mbed-os/features/FEATURE_COMMON_PAL/sal-stack-nanostack-eventloop/source/system_timer.c",313  Warning[Pe546]: transfer of control bypasses initialization of:
            variable "event" (declared at line 318)
make[1]: *** [mbed-os/rtos/TARGET_CORTEX/rtx5/TARGET_RTOS_M4_M7/TOOLCHAIN_IAR/irq_cm4f.o] Segmentation fault (core dumped)
make[1]: *** Deleting file 'mbed-os/rtos/TARGET_CORTEX/rtx5/TARGET_RTOS_M4_M7/TOOLCHAIN_IAR/irq_cm4f.o'
make[1]: *** Waiting for unfinished jobs....
@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 1, 2017

Re-triggering the exporter build as make_iar segmentation fault is fixed
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 2, 2017

@studavekar I did not report status back (the last exporter build)

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 2, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 2, 2017

Fixed now, all green, ready for merge 🎆

@theotherjimmy theotherjimmy merged commit c40b642 into ARMmbed:master Nov 2, 2017

9 of 10 checks passed

ci/morph-export-build Job has completed
Details
AWS-CI uVisor Build & Test Success
Details
AWS-CI uvisor Test DIDNT RUN UVISOR TESTS
Details
Cam-CI uvisor Build & Test DIDNT RUN UVISOR TESTS
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
ci/morph-export-build build completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment