New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and mute debug messages of REALTEK_TRL8195AM #4667

Merged
merged 3 commits into from Jul 13, 2017

Conversation

Projects
None yet
5 participants
@Archcady
Contributor

Archcady commented Jun 29, 2017

No description provided.

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 29, 2017

Thanks, it removes most of the messages

=========================================================

ROM Version: 0.3

Build ToolChain Version: gcc version 4.8.3 (Realtek ASDK-4.8.3p1 Build 2003) 

=========================================================
Check boot type form eFuse
SPI Initial
Image1 length: 0x2d64, Image Addr: 0x10000bc8
Image1 Validate OK, Going jump to Image1

====================================================.
ROM Version: 0.3

Build ToolChain Version: gcc version 4.8.3 (Realtek ASDK-4.8.3p1 Build 2003) 

=========================================================
Check boot type form eFuse
SPI Initial
Image1 length: 0x2d64, Image Addr: 0x10000bc8
Image1 Validate OK, Going jump to Image1

Initializing WIFI ...
WIFI initialized

WIFI is already runningWiFi example

Scan:
Network: Bartek secured: WPA2 BSSID: 22:61:71:72:f:65 RSSI: -38 Ch: 6
Network: AccessNG secured: WPA2 BSSID: 70:3A:E:64:3a:80 RSSI: -46 Ch: 1
Network: Guest-AccessNG secured: None BSSID: 70:3A:E:64:3a:81 RSSI: -46 Ch: 1
Network: AccessNG secured: WPA2 BSSID: 70:3A:E:64:35:20 RSSI: -48 Ch: 11
Network: Guest-AccessNG secured: None BSSID: 70:3A:E:64:35:21 RSSI: -48 Ch: 11
Network: Guest-AccessNG secured: None BSSID: 70:3A:E:64:8d:1 RSSI: -54 Ch: 6
Network: Guest-AccessNG secured: None BSSID: 70:3A:E:64:51:1 RSSI: -56 Ch: 6
Network: AccessNG secured: WPA2 BSSID: 70:3A:E:64:8d:0 RSSI: -56 Ch: 6
Network: Guest-AccessNG secured: None BSSID: 70:3A:E:64:4b:a1 RSSI: -62 Ch: 11
Network: AccessNG secured: WPA2 BSSID: 70:3A:E:64:4b:a0 RSSI: -62 Ch: 11
Network: AccessNG secured: WPA2 BSSID: 70:3A:E:64:5e:40 RSSI: -68 Ch: 11
Network: mbed secured: WPA2 BSSID: 18:D6:C7:52:5f:1e RSSI: -68 Ch: 10
Network: Guest-AccessNG secured: None BSSID: 70:3A:E:64:95:c1 RSSI: -78 Ch: 1
Network: Guest-AccessNG secured: None BSSID: 70:3A:E:5d:65:41 RSSI: -78 Ch: 6
Network: AccessNG secured: WPA2 BSSID: 70:3A:E:5d:63:80 RSSI: -82 Ch: 6
15 networks available.

Connecting...
Success

MAC: f0:03:8c:3c:20:43
IP: 192.168.0.100
Netmask: 255.255.255.0
Gateway: 192.168.0.1
RSSI: -70

Sending HTTP request to www.arm.com...
sent 38 [GET / HTTP/1.1]
recv 64 [HTTP/1.1 200 OK]

Done

Any chance we can get rid of these as well:


Initializing WIFI ...
WIFI initialized

WIFI is already running
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 29, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 30, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 701

Test failed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 769

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 11, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 11, 2017

@Archcady Can you comment on #4667 (comment) ? If its possible to completely remove debug lines?

It shall not block this PR, but would be nice to have

@Archcady

This comment has been minimized.

Contributor

Archcady commented Jul 12, 2017

Oh, yes, I find a way to hide that message, I'll add that to this PR since these are close related. Please help remove the "ready for merge" tag, thanks. @0xc0170 @bulislaw

@bulislaw bulislaw added needs: CI and removed ready for merge labels Jul 12, 2017

@bulislaw

Great thanks, it doesn't print any debug info now. Any chance we could do something like that:

RTWInterface::RTWInterface(bool debug=false)

and set the GlobalDebugEnable accordingly.

@bulislaw bulislaw removed the needs: CI label Jul 12, 2017

@Archcady

This comment has been minimized.

Contributor

Archcady commented Jul 12, 2017

@bulislaw Good idea, I submit another commit, and many thanks.

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jul 12, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 790

All builds and test passed!

@0xc0170 0xc0170 merged commit 43a3612 into ARMmbed:master Jul 13, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment