New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LED4 for UBLOX_EVK_NINA_B1 #4674

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Projects
None yet
5 participants
@andreaslarssonublox
Contributor

andreaslarssonublox commented Jun 30, 2017

Description

Set LED4 the same as LED3 to get tests-mbedmicro-rtos-mbed-timer to pass for UBLOX_EVK_NINA_B1
This is part of getting the target pass mbed Enabled tests.

If not fixed the test will fail with:
[1498813581.77][CONN][RXD] mbed assertation failed: obj->pin != (PinName)NC, file: C:\git\ARMmbed\mCMSIS-RTOS error: User Timer Callback Queue overflow (status: 0x3, task ID: 0x0, timer ID: 0x200053EC)

Status

READY

Migrations

NO

Related PRs

None

Todos

None

Deploy notes

N/A

Steps to test or reproduce

N/A

andreas.larsson
Set LED4 the same as LED3 to get tests-mbedmicro-rtos-mbed-timer to p…
…ass. If set to NC the test will assert.
@AnotherButler

This comment has been minimized.

Contributor

AnotherButler commented Jun 30, 2017

@andreaslarssonublox Thanks for the PR.

Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. We find the commit.template feature particularly helpful. To match this format, please limit your subject line to 50 characters or fewer. We recommend changing it to "Fix LED4 for UBLOX_EVK_NINA_B1" and including the rest of the information in the description.

Thanks for your contributions.

@theotherjimmy

Great diff! Let's test this.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 30, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 30, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 711

Test failed!

@andreaslarssonublox andreaslarssonublox changed the title from Fix LED4 for UBLOX_EVK_NINA_B1 to get tests-mbedmicro-rtos-mbed-timer to pass to Fix LED4 for UBLOX_EVK_NINA_B1 Jul 2, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 7, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 8, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 746

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 10, 2017

@theotherjimmy theotherjimmy merged commit aae62bd into ARMmbed:master Jul 10, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment