New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max32630 UART: Fix IRQ dispatching and CTS/RTS line configuration #4696

Merged
merged 4 commits into from Jul 24, 2017

Conversation

Projects
None yet
6 participants
@pan-
Member

pan- commented Jul 3, 2017

Description

This PR fixes three bugs in the MAX32630 uart implementation:

  • The IRQs were not dispatched because the object requesting the IRQ to be set was not registered.
  • The UART IRQs flags were not clear
  • The CTS/RTS line configuration was incorrect.

Status

READY

Migrations

NO

pan- added some commits Jul 3, 2017

MAX32630: Map UART IRQ to serial object.
Before this change none of the IRQ set would be dispatch to the actual serial object.
@pan-

This comment has been minimized.

Member

pan- commented Jul 3, 2017

@jessexm Could you review this PR ?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

@jessexm Could you review this PR?

@jessexm

Proposed line 122 should reference IOMAN_MAP_B instead of IOMAN_MAP_A.

@pan-

This comment has been minimized.

Member

pan- commented Jul 11, 2017

@jessexm Should be fixed, could you review the changes ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 13, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 14, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 809

Example Build failed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jul 14, 2017

/morph test

1 similar comment
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 17, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 18, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 829

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 18, 2017

@theotherjimmy theotherjimmy merged commit 742d98a into ARMmbed:master Jul 24, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pan- pan- deleted the pan-:max32630_fix_uart branch Nov 14, 2018

@pan- pan- restored the pan-:max32630_fix_uart branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment