New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SystemCoreClock via cmsis.h to support new CMSIS/RTX #4714

Merged
merged 2 commits into from Jul 24, 2017

Conversation

@bulislaw
Member

bulislaw commented Jul 6, 2017

Description

Most platforms do that already, but while updating CMSIS/RTX I hit issues with these two:

  • realtek_rtl8195am @Archcady can you please have a look at changes to this platform
  • sara_nbiot_evk @andreaslarssonublox can you please have a look at changes to this platform

Status

READY

CC @0xc0170

@andreaslarssonublox

This comment has been minimized.

Contributor

andreaslarssonublox commented Jul 6, 2017

Think it's better if @RobMeades reviews it.

@RobMeades

LGTM.

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jul 6, 2017

/morph test

@Archcady

This comment has been minimized.

Contributor

Archcady commented Jul 6, 2017

Looks good to me :)

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 738

Test failed!

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jul 6, 2017

Failure not related to this PR

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 739

Example Build failed!

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jul 6, 2017

Failure not related to this PR

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 740

All builds and test passed!

@adbridge

1 minor change

targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/rtl8195a.h Outdated
@@ -35,6 +35,7 @@
#include "diag.h"
//#include "hal_common.h"
//#include "hal_soc_ps_monitor.h"

This comment has been minimized.

@adbridge

adbridge Jul 7, 2017

Contributor

Why do we have commented out header files ?

This comment has been minimized.

@0xc0170

0xc0170 Jul 10, 2017

Member

@Archcady shall know. this was probably left in place and overlooked until now!

This comment has been minimized.

@Archcady

Archcady Jul 11, 2017

Contributor

I think these two lines can be deleted, must have been forgotten.

This comment has been minimized.

@0xc0170

0xc0170 Jul 11, 2017

Member

Thanks, can you send PR to fix that ? This should not gate this PR

This comment has been minimized.

@Archcady

Archcady Jul 12, 2017

Contributor

Please see #4747 , thanks.

@adbridge adbridge added the needs: work label Jul 7, 2017

targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/rtl8195a.h Outdated
@@ -35,6 +35,7 @@
#include "diag.h"
//#include "hal_common.h"
//#include "hal_soc_ps_monitor.h"

This comment has been minimized.

@0xc0170

0xc0170 Jul 10, 2017

Member

@Archcady shall know. this was probably left in place and overlooked until now!

@0xc0170 0xc0170 added ready for merge and removed needs: work labels Jul 11, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2017

Can you please rebase to resolve conflict?

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Jul 13, 2017

bulislaw added some commits Jul 5, 2017

REALTEK_RTL8195AM: Expose SystemCoreClock via cmsis.h
This change is necessary as updated CMSIS/RTX require the
SystemCoreClock symbol.
sara_nbiot_evk: Expose SystemCoreClock via cmsis.h
This change is necessary as updated CMSIS/RTX require the
SystemCoreClock symbol.

@bulislaw bulislaw force-pushed the bulislaw:expose_systemcoreclock branch to 693a3a8 Jul 13, 2017

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jul 17, 2017

@0xc0170 ping

@0xc0170 0xc0170 removed the needs: work label Jul 17, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 17, 2017

/morph test

@0xc0170 0xc0170 added the needs: CI label Jul 17, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 17, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 823

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 18, 2017

Resolved via another PR from Realtek

@0xc0170 0xc0170 added needs: CI and removed ready for merge labels Jul 18, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 18, 2017

retest uvisor

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 18, 2017

I also restarted Travis, if it fails to update the status here, we can close/reopen to retrigger it again

@0xc0170 0xc0170 closed this Jul 24, 2017

@0xc0170 0xc0170 removed the needs: CI label Jul 24, 2017

@0xc0170 0xc0170 reopened this Jul 24, 2017

@0xc0170 0xc0170 added the needs: CI label Jul 24, 2017

@theotherjimmy theotherjimmy merged commit d5108e5 into ARMmbed:master Jul 24, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment