New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed Enabled certificate for the VBLUno51 board #4719

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
@iotvietmember
Contributor

iotvietmember commented Jul 6, 2017

Description

This PR add new BOARD_ID for the VBLUno51 board.

The mbed Enabled process for the VBLUno51 board

Status

READY

Migrations

NO

Signed-off-by: iotvietmember robotden@gmail.com

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 7, 2017

@iotvietmember please remove the merge commit and do a rebase instead. Thanks

@adbridge adbridge added the needs: work label Jul 7, 2017

@iotvietmember iotvietmember force-pushed the iotvietmember:release_os_5 branch Jul 8, 2017

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Jul 8, 2017

@adbridge I have just fixed those problem. Thanks

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 10, 2017

@iotvietmember Thanks :)

@adbridge adbridge added needs: CI and removed needs: work labels Jul 10, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 10, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 751

All builds and test passed!

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Jul 10, 2017

@adbridge I saw the good results

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

@iotvietmember This PR is on hold until we get 10 samples. See https://www.mbed.com/en/about-mbed/mbed-enabled/#Program_Requirements for more details.

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Jul 11, 2017

@theotherjimmy We have sent 10 samples of the VBLUno51 board for mbed team in Japan on 08 June 2017.
Tracking

And the following file is apply form for mbed Enabled Apply form

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 11, 2017

@theotherjimmy We have sent 10 samples of the VBLUno51 board for mbed team in Japan on 08 June 2017.

cc @toyowata

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Jul 13, 2017

@toyowata Would you please check the mbed Enabled progress for the VBLUno51 board. Many thanks

@toyowata

This comment has been minimized.

Contributor

toyowata commented Jul 13, 2017

I sent the board to Austin/TX team from Japan two days ago. Test engineer will be assigned in that team for the VBLUno51 board.

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Jul 13, 2017

@toyowata @0xc0170 @theotherjimmy Thanks for your support and hope that we will be received the good news from your soon.

iotvietmember added a commit to iotvietmember/mbed-ls that referenced this pull request Jul 21, 2017

Add support for the VBLUno51 board
Email from Sarah Marsh (mbed):
************************************
Hi,

Here is your daplink board ID: C006
The slug: VBLUNO51

When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled:

Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools.

Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable.

Thanks,
Sarah
************************************

The VBLUno51 board was added to mbed-os 5.5.2 released
ARMmbed/mbed-os#4629
ARMmbed/mbed-os#4719

Signed-off-by: iotvietmember <robotden@gmail.com>

iotvietmember added a commit to iotvietmember/pyOCD that referenced this pull request Jul 21, 2017

Add support for the VBLUno51 board
Sarah Marsh (mbed) said that the VBLUno51 board could use board ID is C006
The slug: VBLUNO51

The VBLUno51 board was added to mbed-os 5.5.2 released
ARMmbed/mbed-os#4629
ARMmbed/mbed-os#4719

Signed-off-by: iotvietmember <robotden@gmail.com>

iotvietmember added a commit to iotvietmember/DAPLink that referenced this pull request Jul 21, 2017

Add support for the VBLUno51 board
Email from Sarah Marsh (mbed):
************************************
Hi,

Here is your daplink board ID: C006
The slug: VBLUNO51

When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled:

Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools.

Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable.

Thanks,
Sarah
************************************

The VBLUno51 board was added to mbed-os 5.5.2 released
ARMmbed/mbed-os#4629
ARMmbed/mbed-os#4719

Signed-off-by: iotvietmember <robotden@gmail.com>

iotvietmember added a commit to iotvietmember/DAPLink that referenced this pull request Jul 21, 2017

Add support for the VBLUno51 board
Email from Sarah Marsh (mbed):
************************************
Hi,

Here is your daplink board ID: C006
The slug: VBLUNO51

When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled:

Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools.

Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable.

Thanks,
Sarah
************************************

The VBLUno51 board was added to mbed-os 5.5.2 released
ARMmbed/mbed-os#4629
ARMmbed/mbed-os#4719

Signed-off-by: iotvietmember <robotden@gmail.com>

c1728p9 added a commit to mbedmicro/pyOCD that referenced this pull request Jul 22, 2017

Add support for the VBLUno51 board
Sarah Marsh (mbed) said that the VBLUno51 board could use board ID is C006
The slug: VBLUNO51

The VBLUno51 board was added to mbed-os 5.5.2 released
ARMmbed/mbed-os#4629
ARMmbed/mbed-os#4719

Signed-off-by: iotvietmember <robotden@gmail.com>
@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 19, 2017

Build : SUCCESS

Build number : 259
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4719/

Skipping test trigger, missing label 'NEED CI'

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 31, 2017

@0xc0170, @theotherjimmy, @senthilr Could you please confirm you are happy with the changes ?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 3, 2017

/morph build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 3, 2017

/morph export-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 3, 2017

Build : SUCCESS

Build number : 431
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4719/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Nov 5, 2017

What is the problem?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 6, 2017

What is the problem?

We are currently investigating the K64F failures, not related to this pull request.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 9, 2017

Looks like master is all green starting fresh build

Triggering build

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 9, 2017

Build : SUCCESS

Build number : 482
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4719/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 9, 2017

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Nov 20, 2017

What do I need to do?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 20, 2017

@iotvietmember I think this is waiting on @senthilr's review.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Nov 22, 2017

Hi @iotvietmember, I took a look at why this was failing tests-mbed_drivers-ticker on gcc. Its because UART data is being lost during the test. If flow control is enabled in DAPLink and on the VBLUNO51 then this test passes reliably.

The VBLUno51 board needs to be disabled UART Hardware flow control feature, compatible with nrf51822 target on mbed Online Compiler.

You mentioned that flow control needed to be turned off due to the nrf51822. The VBLUno51 has an nrf51822 on it and it works with flow control. By nrf51822 do you mean a board other than the VBLUno51? If so what board?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jan 2, 2018

@iotvietmember Could you please address address @c1728p9 question ?

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 2, 2018

Automatic CI verification build not done, please verify manually.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 12, 2018

Are we still waiting on DevX/@senthilr's ok, since the MBed page for the hardware is live?

@iotvietmember Ping on @c1728p9's question.

@iotvietmember

This comment has been minimized.

Contributor

iotvietmember commented Jan 16, 2018

@cmonr @adbridge @c1728p9 My board is the VBLUno51 and we hope that we can use 'VBLUNO51' as target name on mbed.
On hardware, the VBLUno51 has UART hardware flow control.

  1. When I created the https://os.mbed.com/platforms/VBLUNO51/, A notice in the upper right corner with content
    "To compile a program for this board using Mbed CLI, use nrf51822 as the target name."
    So I have to cancel the HWFC UART feature on the VBLUno51.

  2. After that, you modified
    "To compile a program for this board using Mbed CLI, use VBLUNO51 as the target name."
    This means that we can use VBLUNO51 as the name of the board on the mbed. This means that the UART HWFC feature is used (fw_daplink_vbluno51_release_1.0.0.bin
    https://os.mbed.com/teams/VNGIoTLab/wiki/vbluno51-interface-firmware)

Many thanks

@cmonr cmonr merged commit a33acaa into ARMmbed:master Jan 22, 2018

6 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 22, 2018

@iotvietmember Thanks for that clarification!

@cmonr cmonr removed the ready for merge label Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment