New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashIAP: Add explicit read function to flash_api.h #4720

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
5 participants
@marcuschangarm
Contributor

marcuschangarm commented Jul 6, 2017

On some platforms, the in-application memory is not memory mapped
and therefore cannot be accessed using memcpy.

The flash_read function added to flash_api.h (with a weak
implementation using memcpy in mbed_flash_api.c) can be used for
reading data from areas that are not memory mapped.

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 6, 2017

@sg- As we discussed.

FlashIAP: Add explicit read function to flash_api.h
On some platforms, the in-application memory is not memory mapped
and therefore cannot be accessed using memcpy.

The flash_read function added to flash_api.h (with a weak
implementation using memcpy in mbed_flash_api.c) can be used for
reading data from areas that are not memory mapped.
@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 6, 2017

I think we need a more unique name than flash_read. I imagine that is quite common in SDKs.

@sg-

sg- approved these changes Jul 7, 2017

LTGM but someone has funky editor settings - looks like yours stripped some dead white space and someone else initially added 👍

@adbridge adbridge added the needs: CI label Jul 7, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 7, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 7, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 744

All builds and test passed!

@sg- sg- added ready for merge and removed needs: CI labels Jul 7, 2017

@theotherjimmy theotherjimmy merged commit efc5c47 into ARMmbed:master Jul 7, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment