New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REALTEK_RTL8195AM: FlashIAP read and address scope #4721

Merged
merged 1 commit into from Jul 24, 2017

Conversation

Projects
None yet
8 participants
@marcuschangarm
Contributor

marcuschangarm commented Jul 6, 2017

Description

The FlashIAP is supposed to have access to the full application
memory, so the address scope has been changed to encompass
the entire external flash.

The address translation has also been changed to reflect the memory
layout in the documentation:

Realtek Ameba1 Memory Layout: 5.1 Flash Memory

Related PRs

Needs API change from #4720 to work.

Tests

Tested using GCC and ARM.

+---------------------------+-------------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| target                    | platform_name     | test suite                  | test case                 | passed | failed | result | elapsed_time (sec) |
+---------------------------+-------------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| REALTEK_RTL8195AM-ARM     | REALTEK_RTL8195AM | tests-mbed_drivers-flashiap | FlashIAP - init           | 1      | 0      | OK     | 0.01               |
| REALTEK_RTL8195AM-ARM     | REALTEK_RTL8195AM | tests-mbed_drivers-flashiap | FlashIAP - program        | 1      | 0      | OK     | 0.17               |
| REALTEK_RTL8195AM-ARM     | REALTEK_RTL8195AM | tests-mbed_drivers-flashiap | FlashIAP - program errors | 1      | 0      | OK     | 0.02               |
| REALTEK_RTL8195AM-GCC_ARM | REALTEK_RTL8195AM | tests-mbed_drivers-flashiap | FlashIAP - init           | 1      | 0      | OK     | 0.01               |
| REALTEK_RTL8195AM-GCC_ARM | REALTEK_RTL8195AM | tests-mbed_drivers-flashiap | FlashIAP - program        | 1      | 0      | OK     | 0.17               |
| REALTEK_RTL8195AM-GCC_ARM | REALTEK_RTL8195AM | tests-mbed_drivers-flashiap | FlashIAP - program errors | 1      | 0      | OK     | 0.02               |
+---------------------------+-------------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

@adbridge Could you review this?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 17, 2017

@c1728p9 Could you review?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 17, 2017

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 17, 2017

@Archcady

This comment has been minimized.

Contributor

Archcady commented Jul 18, 2017

So the flash address starts from 0x0? The Image 1 (0x0000 - 0xAFFF) area is not for application usage, so maybe the flash accessible address should start from 0xB000 (which is start address of Image 2)

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Jul 18, 2017

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 18, 2017

As far as I understand, the purpose of the API is to give unrestricted access to the NVM where the application is stored and users of this API knows that all safeties are off.

@Archcady

This comment has been minimized.

Contributor

Archcady commented Jul 18, 2017

If that's the case, I'll agree to start from 0x0000.

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 18, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 835

Test failed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jul 18, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 18, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 841

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 19, 2017

There was a problem with bot, let me restart the job

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 19, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 850

All builds and test passed!

REALTEK_RTL8195AM: FlashIAP read and address scope
The FlashIAP is supposed to have access to the full application
memory, so the address scope has been changed to encompass
the entire external flash.

The address translation has also been changed to reflect the memory
layout in the documentation:

 Realtek Ameba1 Memory Layout: 5.1 Flash Memory
@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jul 19, 2017

I fixed a bug preventing the mbed-hal flash test to pass.

In some instances the flash_on command wasn't called.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 21, 2017

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 21, 2017

@Archcady please rereview

@Archcady

This comment has been minimized.

Contributor

Archcady commented Jul 21, 2017

Looks good, thanks.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jul 21, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 21, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 858

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 24, 2017

@theotherjimmy theotherjimmy merged commit a3359d6 into ARMmbed:master Jul 24, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment