New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and use custom targets in exporters #4725

Merged
merged 2 commits into from Jul 13, 2017

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Jul 7, 2017

Resolves #4709

Also changes the API of the exporters to be more flexible WRT changes in
TARGET_MAP. The old API would pre-compute a supported list at import time.
This new API includes a class method for computing support for one target
or all targets. This might improve performace for single exports, as only
the current combination of support is checked instead of the whole matrix.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 7, 2017

output

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 7, 2017

The actual mbed export command takes ~550ms with this patch. I tested what mbed export runs, so what this PR actually affects. mbed CLI in general adds ~350 ms of latency on my machine.

@theotherjimmy theotherjimmy requested a review from sarahmarshy Jul 7, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 7, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 7, 2017

@amq does this resolve #4709 for you?

@amq

This comment has been minimized.

Contributor

amq commented Jul 8, 2017

@theotherjimmy yes 👍

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 10, 2017

@theotherjimmy Who should review this change?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

Good question, @0xc0170. I don't know. Maybe @sarahmarshy?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 10, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 83

All exports and builds passed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

@adbridge LGTM!

@0xc0170 0xc0170 merged commit 692d905 into ARMmbed:master Jul 13, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment