New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct DAC pin assignment #4732

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Jul 10, 2017

Description


Bug

Target
DISCO_L053C8
NUCLEO_L053R8

Toolchain:
ALL

mbed-os sha:
efc5c47

Resolves #4730

@bcostm @LMESTM Could you review?

@LMESTM

This comment has been minimized.

Contributor

LMESTM commented Jul 11, 2017

Also adding @jeromecoutant

@LMESTM

LMESTM approved these changes Jul 11, 2017

@LMESTM

This comment has been minimized.

Contributor

LMESTM commented Jul 11, 2017

the change looks good to me - one pending action though is
"Check also all STM32 devices having one single DAC output" ...

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jul 11, 2017

"Check also all STM32 devices having one single DAC output"

Done

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 11, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 11, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 783

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 14, 2017

@theotherjimmy theotherjimmy merged commit 1f23f74 into ARMmbed:master Jul 17, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@theotherjimmy theotherjimmy deleted the theotherjimmy:bcostm-pinmap branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment