New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRF52832: Extend idle thread stack size to 512 bytes. #4736

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
5 participants
@pan-
Member

pan- commented Jul 11, 2017

Description

Fix a crash where the idle thread stack size overflows. This crash
was depending on the compiler and standard library used.

Status

READY

Migrations

NO

NRF52832: Extend idle thread stack size to 512 bytes.
Fix a crash where the idle thread stack size overflows. This crash
was depending on the compiler and standard library used.
@pan-

This comment has been minimized.

Member

pan- commented Jul 11, 2017

@0xc0170 Should resolve #4735 . I would like to have this fix included in 5.5.3.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 11, 2017

/morph test

@marisabele

Fix works for TARGET_MCU_NRF52832

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 782

All builds and test passed!

@0xc0170 0xc0170 merged commit 08dfc84 into ARMmbed:master Jul 13, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thinkberg

This comment has been minimized.

Contributor

thinkberg commented Nov 5, 2017

I am still having this issue on the NRF52832. Increasing it to 768 works so far. I was wondering, why is there no guard like in mbed_rtx_conf.h?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 6, 2017

@thinkberg Please create an issue with details how to reproduce the issue.

@thinkberg

This comment has been minimized.

Contributor

thinkberg commented Nov 6, 2017

I would like to, but I may have a questions regarding that, like what influences the stack usage of the idle task, so I can try to reproduce without exposing all code.

@pan-

This comment has been minimized.

Member

pan- commented Nov 6, 2017

The compiler, its version and the compilation options are the main cause of idle thread stack size overflows.

Until static analysis is used to determine the maximum depth of the idle thread stack on every build, I'm afraid there is no reliable solution.

@thinkberg

This comment has been minimized.

Contributor

thinkberg commented Nov 6, 2017

Then it would make sense to have a guard and be able to set the size in the config, because right now I have to patch mbed-os directly.

@pan- pan- deleted the pan-:fix_nrf52_idle_stack branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment