New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONME-3113: Fix GCC_ARM and ARM compiler warnings from mbed-mesh-api #4738

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
6 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Jul 11, 2017

This PR replaces the #4678 by limiting the scope for files that our team maintains.
I squashed two of @KariHaapalehto commits together and submitted as a new PR.

Description

Fix some compiler warnings from mesh-api

Status

READY

Migrations

NO

ONME-3113: Fix GCC_ARM and ARM compiler warnings from mbed-mesh-api
Warning #1300-D: inherits implicit virtual
- Adding the virtual keyword in the derived class prevents the warning

Warning #1-D: last line of file ends without a newline
- New line added at the end of file

Warning #997-D:
function "MeshInterfaceNanostack::initialize(NanostackPhy *)" is hidden
by "ThreadInterface::initialize"  -- virtual function override intended?
- virtual keyword removed from "MeshInterfaceNanostack::initialize"

Warning #1300-D: inherits implicit virtual
- Adding the virtual keyword in the derived class prevents the warning

@SeppoTakalo SeppoTakalo referenced this pull request Jul 11, 2017

Closed

[ONME-3113] Fix GCC_ARM and ARM compiler warnings #4678

0 of 2 tasks complete

@SeppoTakalo SeppoTakalo requested a review from kjbracey-arm Jul 11, 2017

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jul 12, 2017

java.io.IOException: remote file operation failed: c:\jsbld\ws\mbed-os\mbed-os-pr-uvisor-test-pipeline@8 at hudson.remoting.Channel@719875d1:e104819_builds: java.nio.file.DirectoryNotEmptyException: c:\jsbld\ws\mbed-os\mbed-os-pr-uvisor-test-pipeline@8\autogen\2\mbed-os\targets\TARGET_ublox\TARGET_HI2110\device
	at hudson.FilePath.act(FilePath.java:986)
	at hudson.FilePath.act(FilePath.java:968)
	at hudson.FilePath.deleteRecursive(FilePath.java:1170)
	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:68)
	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:61)

How can I restart the Cam-CI uvisor Build & Test?

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jul 12, 2017

retest uvisor

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 12, 2017

retest uvisor

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 17, 2017

@geky Could you review?

@geky

geky approved these changes Jul 17, 2017

This looks fine to me

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 17, 2017

Thanks!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 24, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 24, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 870

Test failed!

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jul 25, 2017

From http://mbed-ci-master-2.austin.arm.com:8081/job/test_matrix/765/target=NCS36510,toolchain=IAR/testReport/junit/NCS36510-IAR/tests-events-timing/tests_events_timing/

Standard Output

[1500923562.47][HTST][INF] host test executor ver. 1.1.9
[1500923562.47][HTST][INF] copy image onto target...
[1500923562.48][COPY][INF] Waiting up to 60 sec for '120000004420312059465238323032203631303297969903' mount point (current is 'I:')...
        1 file(s) copied.
[1500923582.19][HTST][INF] starting host test process...
[1500923642.22][HTST][ERR] Conn process failed to start in 60.000000 sec
[1500923642.22][HTST][INF] {{result;timeout}}

Does not seem to relate to this one..
@0xc0170 Can you restart the test please.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 25, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 25, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 881

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 25, 2017

Waiting for one fix to resolve a build error, will restart CI once that is done (thus aborted)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 25, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 25, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 884

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 26, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 894

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 3f52924 into ARMmbed:master Jul 27, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment