New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUC472/M453: Fix several startup and hal bugs #4832

Merged
merged 12 commits into from Aug 14, 2017

Conversation

Projects
None yet
7 participants
@ccli8
Contributor

ccli8 commented Jul 31, 2017

Description

This PR includes enhancements and bugfixes for NUMAKER_PFM_NUC472 and NUMAKER_PFM_M453 targets.

  1. Fix region end address error with IAR toolchain.
  2. Fix RTC time doesn't continue across reset cycle.
  3. Conform to mbed TLS H/W acceleration support (NUC472).
  4. Move target configuration from mbed_lib.json to targets.json.
  5. Fix SPI mode error.
  6. Other code and comment refinement.
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 31, 2017

@ccli8 Thanks for the PR. We use the PR titles in release notes, which are formatted with markdown. The [ and ] characters are markdown syntax for a link, which I don't thin is your intent. Could you replace them with a :? Further, we prefer that the release notes use the imparative mood. Could you change the title to match that? I think something like NUC472/M453: Fix several startup and hal bugs would meet these requirements, and better describe the contents of the PR.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 31, 2017

@ccli8 The travis CI error is related to #4839 and should be resolved if you rebase.

@ccli8 ccli8 changed the title from [NUC472/M453] Some enhancements and bugfixes to NUC472/M453: Fix several startup and hal bugs Aug 1, 2017

@ccli8 ccli8 force-pushed the OpenNuvoton:nuvoton branch to 6b8724b Aug 1, 2017

@ccli8

This comment has been minimized.

Contributor

ccli8 commented Aug 1, 2017

@theotherjimmy I've changed the PR title and rebase. Please check it.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 1, 2017

It would be easier to send this as separate patches. Helps to review/integrate.

These commits are nice series of logical patches 👍

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2017

Conform to mbed TLS H/W acceleration support (NUC472).

@RonEld @yanesca @andresag01 Please review

@0xc0170

0xc0170 approved these changes Aug 9, 2017

LGTM, just that small one that does not affect functionality.

}
// NOTE: Check RTC Init Active flag to support crossing reset cycle.
return !! (RTC->INIT & RTC_INIT_ACTIVE_Msk);

This comment has been minimized.

@0xc0170

0xc0170 Aug 9, 2017

Member

this double !! is not necessary here?

This comment has been minimized.

@ccli8

ccli8 Aug 9, 2017

Contributor

@0xc0170 The double !! converts non-0 value to 1. In mbed-os/hal/rtc_api.h:

/** Get the RTC enable status
 *
 * @retval 0 disabled
 * @retval 1 enabled
 */
int rtc_isenabled(void);
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 996

Build failed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 11, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1010

Build Prep failed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 11, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 11, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1018

Build Prep failed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 11, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1022

All builds and test passed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 14, 2017

Conform to mbed TLS H/W acceleration support (NUC472).
@RonEld @yanesca @andresag01 Please review

Any review?

@theotherjimmy theotherjimmy merged commit 0f0a461 into ARMmbed:master Aug 14, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RonEld

I added one small comment, of unneeded definitions in mbedtls_device.h

#define MBEDTLS_SHA256_ALT
#define MBEDTLS_AES_ALT
#define MBEDTLS_AES_SETKEY_ENC_ALT

This comment has been minimized.

@RonEld

RonEld Aug 16, 2017

Contributor

if MBEDTLS_AES_ALT is defined, no need to define other Alternative configuration for AES, as MBEDTLS_AES_ALT defines alternative implementation for the whole module

This comment has been minimized.

@ccli8

ccli8 Aug 17, 2017

Contributor

@RonEld I fixed it. Please check another PR 63e4fb8.

exmachina-auto-deployer pushed a commit to exmachina-dev/mbed-os that referenced this pull request Sep 13, 2017

Merge tag 'mbed-os-5.5.6' of github.com:ARMmbed/mbed-os into 5.5.6
mbed OS 5.5.6 release

We are pleased to announce the [mbed OS 5.5.6
release](https://github.com/ARMmbed/mbed-os/releases/tag/mbed-os-5.5.6)
is now available.

This release includes ...

Known Issues

The following list of known issues apply to this release:

Contents

Ports for Upcoming Targets

[4608](ARMmbed#4608)
Support Nuvoton's new target NUMAKER_PFM_M487

[4840](ARMmbed#4840)
Add Support for TOSHIBA TMPM066 board

Fixes and Changes

[4801](ARMmbed#4801)
STM32 CAN: Fix issue with speed function calculation

[4808](ARMmbed#4808)
Make HAL & US tickers idle safe

[4812](ARMmbed#4812)
Use DSPI SDK driver API's in SPI HAL driver

[4832](ARMmbed#4832)
NUC472/M453: Fix several startup and hal bugs

[4842](ARMmbed#4842)
Add call to DAC_Enable as this is no longer done as part

[4849](ARMmbed#4849)
Allow using of malloc() for reserving the Nanostack's heap.

[4850](ARMmbed#4850)
Add list of defines to vscode exporter

[4863](ARMmbed#4863)
Optimize memory usage of wifi scan for REALTEK_RTW8195AM

[4869](ARMmbed#4869)
HAL LPCs SPI: Fix mask bits for SPI clock rate

[4873](ARMmbed#4873)
Fix Cortex-A cache file

[4878](ARMmbed#4878)
STM32 : Separate internal ADC channels with new pinmap

[4392](ARMmbed#4392)
Enhance memap, and configure depth level

[4895](ARMmbed#4895)
Turn on doxygen for DEVICE_* features

[4817](ARMmbed#4817)
Move RTX error handlers into RTX handler file

[4902](ARMmbed#4902)
Using CMSIS/RTX Exclusive access macro

[4923](ARMmbed#4923)
fix export static_files to zip

[4844](ARMmbed#4844)
bd: Add ProfilingBlockDevice for measuring higher-level applications

[4896](ARMmbed#4896)
target BLUEPILL_F103C8 compile fix

[4921](ARMmbed#4921)
Update gcc-arm-embedded PPA in Travis

[4926](ARMmbed#4926)
STM32L053x8: Refactor NUCLEO_L053R8 and DISCO_L053C8 targets

[4831](ARMmbed#4831)
Remove excessive use of printf/scanf in mbed_fdopen/_open

[4922](ARMmbed#4922)
bug fix: xdot clock config

[4935](ARMmbed#4935)
STM32: fix F410RB vectors size

[4940](ARMmbed#4940)
Update mbed-coap to version 4.0.9

[4941](ARMmbed#4941)
Update of MemoryPool.h header file.

You can fetch this release from the [mbed-os
GitHub](https://github.com/ARMmbed/mbed-os) repository,
using the tag "mbed-os-5.5.6".

Please feel free to ask any questions or provide feedback on this
release [on the forum](https://forums.mbed.com/),
or to contact us at [support@mbed.org](mailto:support@mbed.org).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment