New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating mbed-coap to version 4.0.8 #4833

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
5 participants
@yogpan01
Contributor

yogpan01 commented Jul 31, 2017

Description

Fixes errors reported in Github

  • #4798
    • Fixed Lwm2m blockwise data transfer (using Block1 option) with Leshan
  • ARMmbed/mbed-client#512
    • Fixed an ongoing blocktransfer (Block 1 option) interruption by out of order Block to return error 4.08 Request Entity Incomplete as specified in the coap specification.
  • ARMmbed/mbed-client#511
    • Fixed detected duplicate message duplications will not stop mbed-client

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

List related PRs against other branches:
ARMmbed/mbed-coap#29
ARMmbed/mbed-coap#28
ARMmbed/mbed-coap#25

@yogpan01 yogpan01 changed the title from Fixes for IOTCLT-1885, IOTCLt-1880 to Fixes for IOTCLT-1885, IOTCLT-1880 Jul 31, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 31, 2017

@yogpan01 We use the PR titles is release notes, and I would not expect anyone to know what anything IOTCLT-* means. Could you update the title to reflect what you're fixing?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 31, 2017

@yogpan01 We use the PR titles is release notes, and I would not expect anyone to know what anything IOTCLT-* means. Could you update the title to reflect what you're fixing?

Same for the commit message 👍

@yogpan01 yogpan01 force-pushed the yogpan01:master branch Aug 1, 2017

@yogpan01 yogpan01 changed the title from Fixes for IOTCLT-1885, IOTCLT-1880 to Fixes for IOTCLT-1885, IOTCLT-1880, IOTCLT-1883 Aug 1, 2017

@yogpan01 yogpan01 changed the title from Fixes for IOTCLT-1885, IOTCLT-1880, IOTCLT-1883 to Fixes for mbed-coap issues #4798 , mbed-client issue - 512, 511 Aug 1, 2017

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Aug 1, 2017

@0xc0170 I have updated the PR title, the PR is fix for the issues reported in Github and I have updated the issue number in the title as well as in comment section.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 1, 2017

@yogpan01 We recommend that you describe what you are fixing instead of referencing issues, as this is easier to understand it the release notes. Could you add a short description of what you are fixing in the title and commit messages instead of the issue numbers? It looks like you updated the mbed-coap library, so something like Update mbed-coap to version 4.0.8 might be easier to understand.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 7, 2017

@yogpan01 We recommend that you describe what you are fixing instead of referencing issues, as this is easier to understand it the release notes. Could you add a short description of what you are fixing in the title and commit messages instead of the issue numbers? It looks like you updated the mbed-coap library, so something like Update mbed-coap to version 4.0.8 might be easier to understand.

Can you please update? We will then start the CI

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Aug 8, 2017

@anttiylitokola Can you please update the PR title and description as requested by @0xc0170 ?

@anttiylitokola

This comment has been minimized.

Contributor

anttiylitokola commented Aug 8, 2017

@yogpan01, This data is coming from your own fork so I do not have rights to update anything here.

@yogpan01 yogpan01 changed the title from Fixes for mbed-coap issues #4798 , mbed-client issue - 512, 511 to Updating mbed-coap to version 4.0.8 Aug 8, 2017

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Aug 8, 2017

@0xc0170 I have updated the title and also added some information about the actual issues that were fixed in description. Is this ok now ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 8, 2017

@0xc0170 I have updated the title and also added some information about the actual issues that were fixed in description. Is this ok now ?

Almost, the most important part is being it part of the commit (github description then can be the same). if you can ammend the commit to include that info, would be appreciated. helps a lot

Updating mbed-coap to version 4.0.8
Fixes errors reported in Github

 - #4798
   - Fixed Lwm2m blockwise data transfer (using Block1 option) with Leshan
 - ARMmbed/mbed-client#512
   - Fixed an ongoing blocktransfer (Block 1 option) interruption by out of order Block to return error 4.08 Request Entity Incomplete as specified in the coap specification.
 - ARMmbed/mbed-client#511
   - Fixed detected duplicate message duplications will not stop mbed-client

@yogpan01 yogpan01 force-pushed the yogpan01:master branch to 02ec653 Aug 8, 2017

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Aug 8, 2017

@0xc0170 Done the update on the commit. Please let me know, if this is fine now.

@0xc0170

0xc0170 approved these changes Aug 8, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 8, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 8, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 8, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 963

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 9, 2017

@theotherjimmy theotherjimmy merged commit 61d486a into ARMmbed:master Aug 10, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment