New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM_CortexM0P uses uninitialized memory in i2c and uses out of bounds array in pwmout #4852

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
5 participants
@janjongboom
Contributor

janjongboom commented Aug 3, 2017

I know these are mbed 2 targets, but I still think we should fix these bugs.

Found them using cppcheck.

@0xc0170

0xc0170 approved these changes Aug 3, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 3, 2017

Can you update the commit message (maximum 50 characters) otherwise it wraps around as you can spot here.

@0xc0170 0xc0170 added the needs: CI label Aug 3, 2017

@loverdeg-ep

This comment has been minimized.

loverdeg-ep commented Aug 4, 2017

More or less off topic but can somebody bump Microchip/Atmel to get SAM support for mbedOS 5?
I've been pushing them on it but they think there isn't much adoption and thus stopped support.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 7, 2017

/morph test

SAM_CortexM0P HAL accesses uninitialized memory
Uses uninitialized memory in I2C, and accesses an out of band array in pwmout

@janjongboom janjongboom force-pushed the janjongboom:cortexm0p_bugs branch to f9d0304 Aug 7, 2017

@janjongboom

This comment has been minimized.

Contributor

janjongboom commented Aug 7, 2017

0xc0170 pushed new commit message

@0xc0170

0xc0170 approved these changes Aug 7, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 7, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 7, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 7, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 7, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 951

Build failed!

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 7, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 957

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 976

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 10, 2017

@theotherjimmy theotherjimmy merged commit 00ab1fd into ARMmbed:master Aug 10, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment