New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cortex-A cache file #4873

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
6 participants
@0xc0170
Member

0xc0170 commented Aug 8, 2017

This was removed during cmsis5 update. Here is original file:
https://github.com/ARMmbed/mbed-os/blob/mbed-os-5.4/cmsis/TOOLCHAIN_IAR/TARGET_CORTEX_A/cache.s

This was pointed out to me in one of the issues here, can't recall to reference this. That this file is missing and should be reverted.

cc @TomoYamanaka @toyowata Please review

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_cortexa_cache branch Aug 8, 2017

@toyowata

This comment has been minimized.

Contributor

toyowata commented Aug 9, 2017

@0xc0170
It looks good to me. The PR is for IAR toolchain and I do no think this fix the issue here, right?
#4759 (comment)

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Aug 9, 2017

@0xc0170

LGTM

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_cortexa_cache branch Aug 9, 2017

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_cortexa_cache branch to 0eb4cf0 Aug 9, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2017

@toyowata 👍 added also gcc ,that one I missed

This now fixes #4759

@toyowata

This comment has been minimized.

Contributor

toyowata commented Aug 9, 2017

@0xc0170 great, thank you.

@0xc0170 0xc0170 changed the title from IAR: add cortex-a cache file to Add cortex-a cache file Aug 9, 2017

@0xc0170 0xc0170 changed the title from Add cortex-a cache file to Fix Cortex-A cache file Aug 9, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 9, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 972

Example Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 9, 2017

/morph test

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 10, 2017

/morph test

1 similar comment
@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 11, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1012

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 11, 2017

/morph test

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 11, 2017

Looks like IAR build was failing for 3 platform KL43Z, NUCLEO_L073RZ, NUCLEO_L486RG

    [DEBUG] Return: 3
    [DEBUG] Output: Out of memory
    [DEBUG] Output: Fatal error detected, aborting.

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1023

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 14, 2017

@theotherjimmy theotherjimmy merged commit 86abcc9 into ARMmbed:master Aug 14, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

exmachina-auto-deployer pushed a commit to exmachina-dev/mbed-os that referenced this pull request Sep 13, 2017

Merge tag 'mbed-os-5.5.6' of github.com:ARMmbed/mbed-os into 5.5.6
mbed OS 5.5.6 release

We are pleased to announce the [mbed OS 5.5.6
release](https://github.com/ARMmbed/mbed-os/releases/tag/mbed-os-5.5.6)
is now available.

This release includes ...

Known Issues

The following list of known issues apply to this release:

Contents

Ports for Upcoming Targets

[4608](ARMmbed#4608)
Support Nuvoton's new target NUMAKER_PFM_M487

[4840](ARMmbed#4840)
Add Support for TOSHIBA TMPM066 board

Fixes and Changes

[4801](ARMmbed#4801)
STM32 CAN: Fix issue with speed function calculation

[4808](ARMmbed#4808)
Make HAL & US tickers idle safe

[4812](ARMmbed#4812)
Use DSPI SDK driver API's in SPI HAL driver

[4832](ARMmbed#4832)
NUC472/M453: Fix several startup and hal bugs

[4842](ARMmbed#4842)
Add call to DAC_Enable as this is no longer done as part

[4849](ARMmbed#4849)
Allow using of malloc() for reserving the Nanostack's heap.

[4850](ARMmbed#4850)
Add list of defines to vscode exporter

[4863](ARMmbed#4863)
Optimize memory usage of wifi scan for REALTEK_RTW8195AM

[4869](ARMmbed#4869)
HAL LPCs SPI: Fix mask bits for SPI clock rate

[4873](ARMmbed#4873)
Fix Cortex-A cache file

[4878](ARMmbed#4878)
STM32 : Separate internal ADC channels with new pinmap

[4392](ARMmbed#4392)
Enhance memap, and configure depth level

[4895](ARMmbed#4895)
Turn on doxygen for DEVICE_* features

[4817](ARMmbed#4817)
Move RTX error handlers into RTX handler file

[4902](ARMmbed#4902)
Using CMSIS/RTX Exclusive access macro

[4923](ARMmbed#4923)
fix export static_files to zip

[4844](ARMmbed#4844)
bd: Add ProfilingBlockDevice for measuring higher-level applications

[4896](ARMmbed#4896)
target BLUEPILL_F103C8 compile fix

[4921](ARMmbed#4921)
Update gcc-arm-embedded PPA in Travis

[4926](ARMmbed#4926)
STM32L053x8: Refactor NUCLEO_L053R8 and DISCO_L053C8 targets

[4831](ARMmbed#4831)
Remove excessive use of printf/scanf in mbed_fdopen/_open

[4922](ARMmbed#4922)
bug fix: xdot clock config

[4935](ARMmbed#4935)
STM32: fix F410RB vectors size

[4940](ARMmbed#4940)
Update mbed-coap to version 4.0.9

[4941](ARMmbed#4941)
Update of MemoryPool.h header file.

You can fetch this release from the [mbed-os
GitHub](https://github.com/ARMmbed/mbed-os) repository,
using the tag "mbed-os-5.5.6".

Please feel free to ask any questions or provide feedback on this
release [on the forum](https://forums.mbed.com/),
or to contact us at [support@mbed.org](mailto:support@mbed.org).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment