New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify LED error sequence to be more recognisable #4920

Merged
merged 2 commits into from Aug 24, 2017

Conversation

Projects
None yet
8 participants
@scartmell-arm
Contributor

scartmell-arm commented Aug 16, 2017

Reopening this PR from the previous PR. I accidentally closed the previous one.

Unified the LED error sequence for all boards. Previously the LED sequence for boards with 4 LEDs was a patterned sequence, and for other boards, a fixed blinking LED. The new sequence is a repeating sequence of 4 fast pulses, followed by 4 slow pulses.

Fixes #1295 LED error patterns

scartmell-arm added some commits Aug 9, 2017

Modify LED error sequence to be more recognisable
The current error sequence for microcontrollers with less than 4 LEDs is
to toggle an LED at a fixed rate. Change the sequence to 4 short pulses
followed by 4 long pulses.
Unified the LED error pattern for all boards
  - Removed the patterned LED sequence, all boards now use the 4 fast pulse, 4 slow pulses LED sequence.
  - Changed the LED used from LED_RED to LED1. Only 58/174 targets seem to define LED_RED but they all define LED1.
  - Removed all ERROR_RED and ERROR_PATTERN definitions from targets/targets.json
@theotherjimmy

Beautiful. Clear and concise diff. 2x 👍

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 17, 2017

/morph test

@0xc0170 0xc0170 added the needs: CI label Aug 17, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 17, 2017

/morph echo

1 similar comment
@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 17, 2017

/morph echo

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 17, 2017

I recieved your comment! Here's what you wrote!

/morph echo

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 21, 2017

/morph test

1 similar comment
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 21, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 22, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1066

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 22, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2017

@deepikabhavnani @c1728p9 @bulislaw Happy with unifying the LED sequence?

@theotherjimmy theotherjimmy merged commit 7252447 into ARMmbed:master Aug 24, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Sissors

This comment has been minimized.

Contributor

Sissors commented Aug 24, 2017

Woohoo :)

@scartmell-arm scartmell-arm deleted the scartmell-arm:led-error-sequence branch Sep 1, 2017

@adbridge adbridge referenced this pull request Sep 12, 2017

Merged

Stm32 flash update #4980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment