New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBLOX_EVK_ODIN_W2- add BUTTON1/2 definitions #4951

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
5 participants
@JanneKiiskila
Contributor

JanneKiiskila commented Aug 22, 2017

UBLOX_ODIN_EVK_W2 is missing the abstract button definitions originally
introduced with PR #4249.

Fix two tab to spaces issues on the go as well.

Description

Fix abstract buttons for UBLOX_EVK_ODIN_W2.

Status

READY

Migrations

NO

Related PRs

Todos

  • Tests
  • Documentation

Mbed OS generic documentation for board porting would have to list the abstract button definition as a requirement.

Deploy notes

N/A

Steps to test or reproduce

Compile a test app which used BUTTON1 or BUTTON2.

UBLOX_ODIN_EVK_W2 - add BUTTON1/2 definitions
UBLOX_ODIN_EVK_W2 is missing the abstract button definitions originally
introduced with PR #4249.

Fix two tab to spaces issues on the go as well.
@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Aug 22, 2017

Fixes issue #4880.

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Aug 22, 2017

@sg- @adbridge - please patch to mbed OS 5.5.6.

@0xc0170 0xc0170 added the needs: CI label Aug 22, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2017

/morph test

1 similar comment
@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 24, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 24, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1106

Build failed!

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Aug 28, 2017

Seems to be failing in something completely irrelevant, are your CI tests working? Doesn't look so.

        Compile [ 87.3%]: startup_efm32wg.S
        [DEBUG] Compile: /usr/local/iccarm-7.80.1/bin/iasmarm --cpu Cortex-M4F -DEFM32WG990F256 -D__CORTEX_M4 -DMBED_STACK_STATS_ENABLED=1 -DARM_MATH_CM4 -D__FPU_PRESENT=1 -D__MBED_CMSIS_RTOS_CM -DMBED_TRAP_ERRORS_ENABLED=1 -D__CMSIS_RTOS -DTRANSACTION_QUEUE_SIZE_SPI=4 -DMBED_HEAP_STATS_ENABLED=1 -f /home/jenkins/mbed_jenkins_iar_01_b10/workspace/bm_wrap/1199/mbed-os/BUILD/tests/EFM32WG_STK3800/IAR/.includes_9ac6a8b2b9411ed1facdc46fd74142bd.txt -o /home/jenkins/mbed_jenkins_iar_01_b10/workspace/bm_wrap/1199/mbed-os/BUILD/tests/EFM32WG_STK3800/IAR/targets/TARGET_Silicon_Labs/TARGET_EFM32/TARGET_EFM32WG/device/TARGET_256K/TOOLCHAIN_IAR/startup_efm32wg.o /home/jenkins/mbed_jenkins_iar_01_b10/workspace/bm_wrap/1199/mbed-os/targets/TARGET_Silicon_Labs/TARGET_EFM32/TARGET_EFM32WG/device/TARGET_256K/TOOLCHAIN_IAR/startup_efm32wg.S
        [DEBUG] Return: -11

@studavekar @adbridge

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 28, 2017

/morph test

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 28, 2017

There was an IAR build issue which is fixed #4879

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 29, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1130

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 29, 2017

@theotherjimmy theotherjimmy merged commit 82f5ce2 into ARMmbed:master Aug 29, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment