New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootloader support for DISCO_L476VG #4958

Merged
merged 4 commits into from Sep 7, 2017

Conversation

Projects
None yet
7 participants
@soramame21
Contributor

soramame21 commented Aug 23, 2017

@MarceloSalazar ThIs function is prepared for call from pal and tested over DISCO_L476VG.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 23, 2017

@LMESTM

I'd prefer this change to not be included in the stm32l4xx_hal layer as this is an official delivery from st.com that we're trying not to modify. This function could be added in the application layer or maybe alternatively in the TARGET_STM32L4/device.h file ?

* @retval Device identifier
*/
void HAL_GetUID_12Byte(uint32_t *UID)
{

This comment has been minimized.

@LMESTM

LMESTM Aug 29, 2017

Contributor

Maybe should you rather name the function with an 's' ? HAL_GetUID_12Bytes ?

This comment has been minimized.

@soramame21

soramame21 Aug 29, 2017

Contributor

@LMESTM thanks for comments. I'll rename and move it to other place.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 29, 2017

Could you fix the parse error in targets.json?

@soramame21

This comment has been minimized.

Contributor

soramame21 commented Aug 31, 2017

@theotherjimmy Thanks for check. I fixed the parse error in targets.json.

@soramame21

This comment has been minimized.

Contributor

soramame21 commented Aug 31, 2017

@LMESTM I had removed the function into mbed-cloud-client-example-internal\platform\mbed-os\TARGET_DISCO_L476VG\pal_plat_DISCO_L476VG.cpp.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 31, 2017

@soramame21 Can you update the name of this pull request? It's just adding bootloader support? How was this tested?

@soramame21 soramame21 changed the title from Add function to read 12byte HW RoT over STM32L4xx. to Add bootloader support on DISCO_L476VG. tested using esp8266 and ARMmbed/mbed-cloud-client-example-internal Aug 31, 2017

@soramame21

This comment has been minimized.

Contributor

soramame21 commented Aug 31, 2017

@0xc0170 Done.

@LMESTM

This comment has been minimized.

Contributor

LMESTM commented Aug 31, 2017

Looks good to me

@0xc0170 0xc0170 changed the title from Add bootloader support on DISCO_L476VG. tested using esp8266 and ARMmbed/mbed-cloud-client-example-internal to Add bootloader support for DISCO_L476VG Aug 31, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 31, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 3, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 3, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1185

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

/morph test

1 similar comment
@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 6, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1228

All builds and test passed!

@0xc0170 0xc0170 merged commit 8dfb491 into ARMmbed:master Sep 7, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0xc0170 0xc0170 removed the ready for merge label Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment