New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable -f option for assembly files for IAR #4977

Merged
merged 1 commit into from Aug 28, 2017

Conversation

Projects
None yet
7 participants
@studavekar
Collaborator

studavekar commented Aug 25, 2017

This fixes IAR build failure #4879 .

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 25, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1120

All builds and test passed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 26, 2017

/morph mbed2-release

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 26, 2017

/morph test

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 26, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 26, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

Output

mbed Build Number: 46

Build failed!

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1124

All builds and test passed!

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1125

All builds and test passed!

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 26, 2017

/morph mbed2-release

@mbed-bot

This comment has been minimized.

mbed-bot commented Aug 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

@studavekar studavekar requested review from sg- and theotherjimmy Aug 26, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 26, 2017

@theotherjimmy can you please review.

cc : @0xc0170 @adbridge @sg-

@sg-

Not sure this would matter but we use .txt extension with -f and the user manual says the extension should be .xcl

From #4879

06:22:52 [DEBUG] Compile: C:\Program Files (x86)\IAR Systems\Embedded Workbench 7.5\arm\bin\iasmarm ... -f .\BUILD\NUCLEO_F767ZI\IAR\.includes_5a547c6d82611f64c4e2715b8a0e2ca1.txt

and

By default, extended command line files have the extension xcl, and can be specified
using the -f command line option. For example, to read the command line options from
extend.xcl, enter:
iasmarm -f extend.xcl

Assuming this doesn't make a difference, what is in the file included by -f that we'd loose?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 28, 2017

@sg-

what is in the file included by -f that we'd loose?

We provide the include directories to the preprocessor via the -f switch. I don't think anyone is relying on including things using the C preprocessor in assembly. As a quick check, find -name '*.S' | rg -e "#include" returns no matches.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 28, 2017

Oh, FYI, rg is my grep (it's actually ripgrep, but that's not super important)

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Aug 28, 2017

@sg- I tried changing the extension to .xcl with the test application that was sent to IAR and iasmarm still crashes.

After this PR goes in and IAR is working with CI, another pr should probably be made to turn off assembly pre-processing include directories for assembly files in the other toolchains.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Aug 28, 2017

As per the development guide -f is C/C++ Compiler option only and should be set in C/C++ Extra options

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 28, 2017

@deepikabhavnani Good point. That might explain why it's not working so well. 😆

@sg-

sg- approved these changes Aug 28, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Aug 28, 2017

If the changes looks good we should merge it to unblock CI.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 28, 2017

Agreed. Just a sec.

@theotherjimmy theotherjimmy merged commit e4d0e12 into ARMmbed:master Aug 28, 2017

6 of 8 checks passed

ci/morph-test Job has completed
Details
ci/morph-test-nightly Job has completed
Details
Cam-CI uvisor Build & Test Success
Details
ci/morph-mbed2-release Job has completed
Details
ci/morph-test Job has completed
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 28, 2017

@studavekar Unblocking CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment