New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed TLS to version 2.6.0 #4987

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
8 participants
@andresag01
Contributor

andresag01 commented Aug 29, 2017

Description

Update mbed OS to use the mbed TLS 2.6.0, the latest released version. For more information on bug fixes, improvements, new features, etc please refer to the mbed TLS ChangeLog.

Status

READY

Migrations

YES

Minor API changes. In particular, two new functions were added to mbed TLS to allow hooks for initialising and freeing system-wide resources before any accelerators, etc are used.

@andresag01

This comment has been minimized.

Contributor

andresag01 commented Aug 29, 2017

@yanesca @sbutcher-arm: Could you please take a look at this PR? Once this is done, I will remove the DRAFT label from the title.

Please note that I have added a new line to the importer/adjust-config.sh script so that MBEDTL_AES_ROM_TABLES is enabled. From the user point of view, this only has the effect of reducing RAM usage at the expense of ROM.

Enable MBEDTLS_AES_ROM_TABLES in mbed TLS main conf
Enable the compile-time option MBEDTLS_AES_ROM_TABLES in the mbed TLS
main config.h file in mbed OS. This option has the effect of labelling
the AES tables as 'const' so they are placed in ROM, which saves some
RAM space.
@yanesca

This comment has been minimized.

Contributor

yanesca commented Aug 29, 2017

Looks good to me.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 2, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1163

All builds and test passed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

@andresag01 Is this ready? There's still DRAFT in the title though. please keep us updated.

Req for 5.6?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

@studavekar I believe this one should go with morph test nightly? (#4987 (comment))

@theotherjimmy theotherjimmy changed the title from DRAFT: Update mbed TLS to version 2.6.0 to Update mbed TLS to version 2.6.0 Sep 5, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 5, 2017

/morph test-nightly

@andresag01

This comment has been minimized.

Contributor

andresag01 commented Sep 6, 2017

@0xc0170: Currently waiting for approval from mbed TLS developers.

@sbutcher-arm

This comment has been minimized.

Contributor

sbutcher-arm commented Sep 6, 2017

This PR is approved by mbed TLS. Just needs CI as far as I can see.

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1225

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 6, 2017

@studavekar Please can you look at the failure, this is the second test I noticed today with arch pro failures (not related for any of these 2 runs).

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 6, 2017

OK, I think I know what is the problem, after looking at the log closer, it's out of heap memory. going to look at the change that could introduce this

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 6, 2017

Depends on #5037

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 7, 2017

I just merged #5037, so testing should be unblocked now.

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 7, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1236

Example Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 7, 2017

We will investigate the failures (it's CI failure not this PR). I restarted on another PR a regular test to find out if this was one time or not.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 8, 2017

/morph test-nightly

1 similar comment
@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 8, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 9, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1261

Test failed!

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 11, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 12, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1284

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 12, 2017

@0xc0170 0xc0170 merged commit de6d291 into ARMmbed:master Sep 12, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment