New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce K64F Ethernet driver to 1 thread #4996

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
5 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Aug 31, 2017

Save 1K of RAM by using only 1 thread for RX and TX, and running the PHY check in lwIP's context.

This makes the driver function more a bit more like the Nanostack one in https://github.com/ARMmbed/sal-nanostack-driver-k64f-eth, and could be viewed as a first step towards unification as an EMAC driver.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:k64f_emac_1thread branch Aug 31, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 31, 2017

Reduce K64F Ethernet driver to 1 thread
Save 1K of RAM by using only 1 thread for RX and TX, and
running the PHY check in lwIP's context.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:k64f_emac_1thread branch to 65639e8 Aug 31, 2017

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Aug 31, 2017

Looks good to me.

@0xc0170

0xc0170 approved these changes Sep 4, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

/morph test-nightly

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 4, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 4, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 5, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1213

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 5, 2017

@theotherjimmy theotherjimmy merged commit 857819f into ARMmbed:master Sep 5, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment