New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cellular APN_db.h lookup. #5016

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
5 participants
@RobMeades
Contributor

RobMeades commented Sep 4, 2017

Description

Look-up of the APN for a cellular connection in APN_db.h was failing because the call to apncfg(), which requires the IMSI, was being made before the IMSI had been retrieved from the modem.

Related PRs

ARMmbed/easy-connect #41

@RobMeades

This comment has been minimized.

Contributor

RobMeades commented Sep 4, 2017

@0xc0170 0xc0170 requested a review from hasnainvirk Sep 5, 2017

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 5, 2017

@RobMeades Can you please walk me through this ? Why are you passing imsi to the apn_config() in a loop ? Isn't that once you pass imsi to apn_config() it gives you all matching results and then you go through those results in a loop ?

@RobMeades

This comment has been minimized.

Contributor

RobMeades commented Sep 5, 2017

apnconfig() sets up the APN db for the IMSI in question, so it needs to be called after the IMSI has been retrieved. _APN_GET() is then called to get the APN, username and password for the MCC/MNC, of that IMSI and must be called multiple times to try all of the possible APNs that may exist for that MCC/MNC if attempts to connect fail.

I had thought that calling setup_context_and_credentials() would set set_credentials_api_used to be true, but I see that it doesn't. I will modify it to check if apn_config is null instead.

@RobMeades RobMeades force-pushed the u-blox:apndb_fix branch to bce900d Sep 5, 2017

@hasnainvirk

Looks good to me.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 5, 2017

@RobMeades Thanks Rob. Understood.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 5, 2017

@0xc0170 Test failing on mbed-os-cliapp/master with ESP8266. RAAS module [wlan-8022]. This commit cannot affect any Wifi tests. Can you please check what happened ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 5, 2017

@0xc0170 Test failing on mbed-os-cliapp/master with ESP8266. RAAS module [wlan-8022]. This commit cannot affect any Wifi tests. Can you please check what happened ?

I restarted the build, did not look to me like related.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 21, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 22, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1362

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 24, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1377

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 26, 2017

The device failure, restartin CI

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 26, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1393

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 27, 2017

@theotherjimmy theotherjimmy merged commit 908a05b into ARMmbed:master Sep 27, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment