New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VK_RZ_A1H with ds5 & e2studio exporters #5052

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
4 participants
@mbedNoobNinja
Contributor

mbedNoobNinja commented Sep 8, 2017

Notes:

  • This is the PR supposed to fix the ds5 & e2studio exporters. but I very much doubt it will fix the online exporter issue.

Description

  • Online Project exporter persistently refuses to work. The details can be found in issue #3768, which obviously continues to be an issue.
  • No information for used RAM and ROM in the online compiler, when compiling projects for VK_RZ_A1H platform.

Steps to test or reproduce

Try to export standard mbed_blinky project for platform VK_RZ_A1H with the online compiler (export option) for toolchains IAR or ds5 or e2studio.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 8, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 8, 2017

@mbedNoobNinja Nice! I'll review now.

@theotherjimmy

Could you comment on my question below?

targets/targets.json Outdated
@@ -2259,7 +2259,7 @@
"supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
"default_toolchain": "ARM",
"program_cycle_s": 2,
"device_has": ["ANALOGIN", "CAN", "ETHERNET", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_FC", "SPI", "SPISLAVE", "STDIO_MESSAGES"],
"device_has": ["ANALOGIN", "CAN", "ETHERNET", "I2C", "I2CSLAVE", "I2C_ASYNCH", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "SPI", "SPISLAVE", "SPI_ASYNCH", "STDIO_MESSAGES"],

This comment has been minimized.

@theotherjimmy

theotherjimmy Sep 8, 2017

Contributor

Why is this change included?

This comment has been minimized.

@mbedNoobNinja

mbedNoobNinja Sep 8, 2017

Contributor

Because it will be needed when the two targets (VK_RZ_A1H and RZ_A1H) are merged look here #4440

... after adding "I2C_ASYNCH", "SPI_ASYNCH" & "SERIAL_ASYNCH" interfaces as "device_has" ittems for the "VK_RZ_A1H" platform in targets.json, the errors disappeared and the test finally managed to run.

This comment has been minimized.

@theotherjimmy

theotherjimmy Sep 8, 2017

Contributor

Right, but that should not be part of this PR, and instead part of another one.

This comment has been minimized.

@mbedNoobNinja

mbedNoobNinja Sep 9, 2017

Contributor

OK it will be removed.

This comment has been minimized.

@mbedNoobNinja

mbedNoobNinja Sep 11, 2017

Contributor

targets.json is reverted ! Happy ?

@mbedNoobNinja mbedNoobNinja force-pushed the mbedNoobNinja:Branch_Export branch to 3ba6620 Sep 11, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 11, 2017

Yup. Looks great!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 27, 2017

/morph export-build

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 29, 2017

/morph export-build

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 29, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 162

All exports and builds passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 29, 2017

@theotherjimmy theotherjimmy merged commit 1a04b0a into ARMmbed:master Sep 29, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-export-build Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@theotherjimmy theotherjimmy changed the title from ds5 & e2studio export fix to Support VK_RZ_A1H with ds5 & e2studio exporters Sep 29, 2017

@mbedNoobNinja mbedNoobNinja deleted the mbedNoobNinja:Branch_Export branch Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment