New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InterruptIn: Use NULL callback by default #5062

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
7 participants
@0xc0170
Member

0xc0170 commented Sep 9, 2017

As we can check if callback was attached, we use NULL assignment.

Just a cosmetic change, that follows what we did for other attach() drivers.

@sg- @geky

InterruptIn: callback to NULL clean-up
As we can check if callback was attached, we use NULL assigment.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2017

cc @pan- @c1728p9 Please review

@geky

geky approved these changes Sep 19, 2017

@pan-

pan- approved these changes Sep 19, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 20, 2017

@theotherjimmy theotherjimmy changed the title from InterruptIn: callback to NULL to InterruptIn: Use NULL callback by default Sep 21, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 27, 2017

/morph test

1 similar comment
@studavekar

This comment has been minimized.

Collaborator

studavekar commented Sep 28, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 28, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1417

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 28, 2017

@theotherjimmy theotherjimmy merged commit 6177c01 into ARMmbed:master Sep 28, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment