New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends test set for EventFlags class #5081

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
7 participants
@maciejbocianski
Member

maciejbocianski commented Sep 12, 2017

Description

New test suite for EventFlags class

Status

READY

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 25, 2017

@0xc0170 Could you take a look?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 29, 2017

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:events_flags_tests branch 2 times, most recently Oct 2, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2017

@maciejbocianski Can you please rebase to resolve circle-ci failure? We will then trigger the Ci test

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 2, 2017

@maciejbocianski @0xc0170 I turned off circle CI. It was just a bad copy of travis CI. You may need to push a commit to re-trigger CI and get the red x off of your commit.

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:events_flags_tests branch Oct 2, 2017

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Oct 2, 2017

done

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 2, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 3, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2017

@maciejbocianski When you do any change, it is beneficial to share how it was tested (how mnay toolchains, targets).

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 4, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1520

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2017

@maciejbocianski PLease look at the results, there are failures related

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Oct 4, 2017

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:events_flags_tests branch Oct 5, 2017

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Oct 5, 2017

@0xc0170 fix added

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:events_flags_tests branch 2 times, most recently Oct 5, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 5, 2017

retest uvisior

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 5, 2017

retest uvisor

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:events_flags_tests branch 4 times, most recently Oct 6, 2017

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:events_flags_tests branch Oct 9, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 9, 2017

@c1728p9 Could you take a look at the new version?

TESTS/mbedmicro-rtos-mbed/event_flags/main.cpp Outdated

#if defined(MBED_RTOS_SINGLE_THREAD)
#error [NOT_SUPPORTED] test not supported
#endif

#define TEST_STACK_SIZE 512
#define THREAD_STACK_SIZE 256 /* 512B stack on GCC_ARM compiler cause out of memory on some 16kB RAM boards */

This comment has been minimized.

@c1728p9

c1728p9 Oct 9, 2017

Contributor

This stack is quite small. Which devices were failing?

This comment has been minimized.

@maciejbocianski

maciejbocianski Oct 9, 2017

Member

test fails on nucleo_f070rb with GCC_ARM compiler on develop profile with 512B and 400B
384B stack is ok, so could be increased a bit to 320B or 350B

This comment has been minimized.

@maciejbocianski

maciejbocianski Oct 11, 2017

Member

stack increased to 320B

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 9, 2017

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:events_flags_tests branch to 0e014c9 Oct 11, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 111
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5081/

Triggering tests

/test mbed-os

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 13, 2017

Build : SUCCESS

Build number : 170
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5081/

Skipping test trigger, missing label 'NEED CI'

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 13, 2017

Build : SUCCESS

Build number : 171
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5081/

Skipping test trigger, missing label 'NEED CI'

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 17, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

/morph uvisor-test

@0xc0170 0xc0170 added needs: CI and removed ready for merge labels Oct 19, 2017

@adbridge adbridge merged commit 4d25bcc into ARMmbed:master Oct 20, 2017

7 checks passed

AWS-CI uVisor Build & Test Success
Details
AWS-CI uvisor Test DIDNT RUN UVISOR TESTS
Details
Cam-CI uvisor Build & Test DIDNT RUN UVISOR TESTS
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment